status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 78 forks source link

Updated fees panel and transaction summary dialog for airdropping, minting, burning, remotely destructing #11550

Closed benjthayer closed 6 months ago

benjthayer commented 1 year ago

With the advent of the Owner token and TokenMaster token, the way fees are taken through contract interactions has changed.

Instead of the token being bound to the address that is selected in the minting form, the Owner and TokenMaster instead select the account from which to pay gas fees for contract interactions with the token.

The latest fee panels and transaction summary dialogs have been rolled out into the following flows:

The fees panel has been made into a component to make it easier to see the variants used throughout these flows: https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=35302-601554&mode=design&t=izrFg3DNSH3R21mU-4

Screenshot 2023-07-17 at 11 20 49

States:

The fetch (skeleton load) state should only be used if the fee fetch/update is not instantaneous. While the dialog is in view, the fees should update according to the block time which will be different depending on the network being used for the transaction. Again, the loading state should only be used if the refresh of the fee is not instantaneous.

A flow showing how the fee panel should look under the various conditions is shown here (in the context of airdrop): https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=35302-602386&mode=design&t=izrFg3DNSH3R21mU-4

--

The same with the Tx summary transaction dialog: https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=35333-606277&mode=design&t=izrFg3DNSH3R21mU-4

Screenshot 2023-07-17 at 11 01 14

--

Flows updated with the above:

Airdrop https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=22602-495365&mode=design&t=izrFg3DNSH3R21mU-4

Mint, airdrop and remotely destruct Owner / TokenMaster tokens https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=34794-589770&mode=design&t=izrFg3DNSH3R21mU-4

Mint, airdrop and remotely destruct collectibles and assets https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=29373-560281&mode=design&t=izrFg3DNSH3R21mU-4

For the remote destruction of a token, note that the dialog has been changed significantly to allow the fees panel to stay in view. All views and interactions for this dialog have been documented here: https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?type=design&node-id=29468-618133&mode=design&t=izrFg3DNSH3R21mU-4

Screenshot 2023-07-17 at 11 14 59

cc @micieslak @John-44 @noeliaSD

alexjba commented 6 months ago

Already implemented

Owner token:

Image

Minting

Image

Image

Airdrop

Image