search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
276 stars 76 forks source link

Improve offline banners #12938

Open igor-sirotin opened 7 months ago

igor-sirotin commented 7 months ago

  1. When the app is offline, only show the offline banner. All other connections issues banners should be hidden. I guess there're 2 possible banners to show together with the OFFLINE: backup seed phrase and testnet mode.

  2. Implement a new banner No connected peers. This should be visible when we have 0 peers, but have connection to the internet. I.e. wallet will work, but messaging won't.

igor-sirotin commented 4 months ago

I'd say this is ui-team?

caybro commented 4 months ago

I'd say this is ui-team?

Yeah I guess so... any more formal description, like link to Figma etc?

igor-sirotin commented 4 months ago

Yeah I guess so... any more formal description, like link to Figma etc?

@caybro nope 🙂 I wrote this during a call from @John-44 words.

caybro commented 4 months ago

Then I guess it's for @benjthayer first at this stage ;)

benjthayer commented 4 months ago

Thanks @igor-sirotin @caybro do we want to recommend the user restart the app if they have 0 peers? I'm not sure if that is the best way to resolve the issue but that is what I've been advised to do in the past when this happens?

igor-sirotin commented 4 months ago

Thanks @igor-sirotin @caybro do we want to recommend the user restart the app if they have 0 peers? I'm not sure if that is the best way to resolve the issue but that is what I've been advised to do in the past when this happens?

Theoretically that shouldn't be something that should help. But if you'd ask me, I'd suggest you the same 😄 Nevertheless, I don't think we should put this recommendation to UI. If we have such a bug that we restart is required to get peers back, then this bug should be addressed. And then such recommendation would be useless.

noeliaSD commented 3 months ago

Still some decision to take. Moved due to lack of capacity

noeliaSD commented 3 weeks ago

@benjthayer @xAlisher it should be nice to have your final feedback here! Thanks

xAlisher commented 2 weeks ago

I agree with Johns input. If we show offline banner, all others, instead of Back up recovery phrase and Testnet mode must be hidden.