status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

Community order has expanded address covering the title #13158

Closed alaibe closed 6 months ago

alaibe commented 8 months ago

image

Khushboo-dev-cpp commented 7 months ago

I could not reproduce this on latest master.

Image

caybro commented 7 months ago

Yeah I remember fixing this already some time ago

alaibe commented 7 months ago

Here issue is that the community name is not being fetched, let me reopen as there is a new design coming

benjthayer commented 7 months ago

Hey @alaibe I've added designs to the relevant flows to cover if the community name could not be fetched:

Community tag inside collectible detail page: NB the collectible detail page linked features the tweaked collectible detail page design as covered in this GH issue

Screenshot 2024-02-19 at 2 52 21 PM

Figma: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21257-30930&mode=design&t=iECJIIPiwRwlmxGd-4

--

Community tag inside Assets detail page:

Screenshot 2024-02-19 at 3 01 04 PM

Figma: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21337-308555&mode=design&t=iECJIIPiwRwlmxGd-4

--

Community tag inside Asset list item:

Screenshot 2024-02-19 at 3 04 34 PM

Figma: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21330-195031&mode=design&t=iECJIIPiwRwlmxGd-4

--

Community tag inside Collectible list item:

Screenshot 2024-02-19 at 3 13 34 PM

Figma: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21292-169137&mode=design&t=iECJIIPiwRwlmxGd-4

--

Community tag inside send dialog: NB the send dialogs linked feature a slight tweak to the layout of the collectibles list to accommodate the Community minted and Other section headers as well as clarifying how the user drills into a community folder to select a collectible. A new issue will be created to summarise these changes.

In the Send dialog we append the first few characters of the community ID to differentiate between multiple communities whose name could not be fetched.

Screenshot 2024-02-19 at 3 24 16 PM

Figma: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21292-150312&mode=design&t=iECJIIPiwRwlmxGd-4

--

Community tag inside Manage tokens:

Screenshot 2024-02-19 at 3 39 36 PM

Figma: https://www.figma.com/file/eM26pyHZUeAwMLviaS1KJn/%E2%9A%99%EF%B8%8F-Wallet-Settings%3A-Manage-Tokens?type=design&node-id=1583-105708&mode=design&t=K1dMxoQwwhi5nXfO-4

https://www.figma.com/file/eM26pyHZUeAwMLviaS1KJn/%E2%9A%99%EF%B8%8F-Wallet-Settings%3A-Manage-Tokens?type=design&node-id=1719-114270&mode=design&t=K1dMxoQwwhi5nXfO-4

benjthayer commented 7 months ago

@alaibe - I've updated the final designs for what we show and what interactions are available for when the community name cannot be fetched. After speaking with Pascal, it seems there isn't any information in the smart contract relating back to the community so the best we can do I feel in this situation is to show Unknown community and the community address on hover with the ability to click to copy the address incase the user wants to investigate further.