status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 78 forks source link

Ability to add ENS domain name as a saved address #13381

Closed benjthayer closed 8 months ago

benjthayer commented 9 months ago

Creating saved address flows updated to include the case of adding an ENS domain as a saved address.

The user should be able to enter an ENS domain into the Address field. The resolver service should ensure the appropriate address is used for the ENS at the point of interaction (e.g. sending tokens to the ENS domain).

When the Address field detects a valid ENS domain, the network preferences section is hidden as it is not applicable/relevant for ENS domain names. When this happens, the dialog should collapse in height to remove the empty space that would be left by the missing section.

Screenshot 2024-02-01 at 6 00 10 PM

Figma https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=23256-263282&mode=design&t=0DRwQJKDGYJPHkq1-4

alaibe commented 9 months ago

@benjthayer are you sure you want jumping button? it may look a bit weird to see element taking other position

benjthayer commented 9 months ago

@benjthayer are you sure you want jumping button? it may look a bit weird to see element taking other position

Hey @alaibe ideally, the network preferences would quickly fade out and the dialog would perform an animated transition into it's smaller state - if we can achieve this subtle motion, I don't think the jump in the dialog resulting from the hiding of the network preferences should be too disorienting. Is something like that possible? The overall transition should be under 1 sec and the reverse transition should happen if the eth address is replaced with an ethereum address.