status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
304 stars 79 forks source link

Refactor: community tokens + permissions token #13464

Open Khushboo-dev-cpp opened 9 months ago

Khushboo-dev-cpp commented 9 months ago

Description

Currently the token item and model here -> https://github.com/status-im/status-desktop/blob/master/src/app/modules/main/communities/tokens/models/token_item.nim

is not deriving from the generic token item declared in wallet token service here -> https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/src/app_service/service/token/service_items.nim#L25

also it creates token dto which ideally should have been used to extend this class and not as a property variable.

It would be good if it can be explored if we really need https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/src/app/modules/main/communities/view.nim#L26C1-L27C1

Khushboo-dev-cpp commented 9 months ago

@noeliaSD @endulab please check if this task has enough inputs as discussed on our discussion yesterday.