search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

Create new permission (Holdings Dropdown) shows incorrect data #13465

Open Khushboo-dev-cpp opened 7 months ago

Khushboo-dev-cpp commented 7 months ago

Bug Report

Description

The holdings drop down should should tokens in 3 sections- 1. Community assets Description: Assets minted by the community Source: as per discussion with Michal I this should be https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/src/app/modules/shared_models/section_item.nim#L59 2. Your assets Description: List of all assets you own (excluding the community assets which will be listed above) Source: https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/src/app/modules/main/wallet_section/assets/view.nim#L11 On Qml side please use https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/ui/app/AppLayouts/Wallet/stores/TokensStore.qml#L78 3. All assets Description: This is a list of al supported token by Status Source: https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/src/app/modules/main/wallet_section/all_tokens/view.nim#L22 On qml side please use https://github.com/status-im/status-desktop/blob/d2030de867c9ffbb1def803569946fa5707fd2e9/ui/app/AppLayouts/Wallet/stores/WalletAssetsStore.qml#L81

Steps to reproduce

  1. Open a community with some minted tokens
  2. go to community management
  3. try to create a new permission

Expected behavior

https://www.figma.com/file/qHfFm7C9LwtXpfdbxssCK3/Kuba%E2%8E%9CDesktop---Communities?type=design&node-id=22721-499832&mode=design&t=Z0VeuAJrCe49uoP6-4

Actual behavior

https://github.com/status-im/status-desktop/assets/60327365/53e913ff-d5bd-462b-bb46-85dbfcc94684

Additional Information

iurimatias commented 6 months ago

moved due to lack fo space in this milestone, but we may pick this up on the stabilization period if possible

noeliaSD commented 5 months ago

Due to priorities and team capacity, moved to next milestone.

noeliaSD commented 3 months ago

After the analysis and work done in wallet domain, I think @micieslak this task can be taken on the next milestone so we can ensure the models used for communities are aligned with the wallet ones.