status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

[Profile Showcase backend] Support assets for the profile showcase for a contact #14129

Closed MishkaRogachev closed 1 week ago

MishkaRogachev commented 5 months ago

Continue https://github.com/status-im/status-desktop/pull/13998

Note: tokens can be requested via buildAllTokens with store = false and collected with SIGNAL_WALLET_ACCOUNT_TOKENS_REBUILT. But this may be dangerous, because signal may be handled with the wallet section, communities and etc. Consider to introduce a fetching id that can be compared with the signal received.

MishkaRogachev commented 5 months ago

Implementation can provide 2 models that can be joined on the Ui side: one for balances and another for unverified (custom, community) tokens metadata. These support assets models should be built based on data from the following endpoints:

1) GetBalancesByChain to obtain balances for provided chainIds and wallet addresses and contract addresses.

2) FindOrCreateTokenByAddress to get custom (community) token metadata: name, symbol, decimal and imageUrl.

jrainville commented 4 months ago

Moving Profile showcase issues to 2.30 for now as it's no longer priority

jrainville commented 1 week ago

Closing as it doesn't seem like we'll support assets in the profile showcase in the end