Open noeliaSD opened 2 months ago
It still need proper decomposition of subtasks.
Some of the listed issues will be covered here: https://github.com/status-im/status-desktop/issues/14618
Next steps: https://github.com/status-im/status-desktop/issues/14715
Description
According to the agreed architecture posted on the shared notion page, update the following identified wallet models following the pattern described.
Goals:
This epic will be solved step by step, considering each model update as a different subtask. Here are the existing wallet models that should be part of the
wallet section/module
:Exposition of context properties from NIM to QML
src/app/modules/main/wallet_section
Sources
property it's not a direct value but an operation that can be a potential performance issueDescription
andWebsiteURL
also to be consideredMarketDetails
can be lazy loaded?? Can we share the same market details object in the flat_tokens_model???walletSectionAccounts
. Can it be removed?shared_modules
profile_section/wallet/accounts/model.nim --> it's the one for settings -- > Can it be removed?
Collectibles model
Stores Some stores are declared as Singletons:
status-desktop/ui/app/AppLayouts/Wallet/stores/RootStore.qml
status-desktop/ui/imports/shared/stores/RootStore.qml
It creates a dependency on context properties and breaks unit tests / storybook pages.Subtasks:
accounts
base model and remove duplications in (send and settings "sections")flat_tokens_model
,Sources
property it's not a direct value but an operation that can be a potential performance issue. ReviewDescription
andWebsiteURL