status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
296 stars 78 forks source link

There is nowhere to enter the sync code in the Syncing settings page #14668

Open jrainville opened 5 months ago

jrainville commented 5 months ago

Bug Report

Description

In the Syncing settings info, it says this: image

and when you click "Setup syncing", you see : image

However, nowhere in the Syncing screen does it have a Enable camera button or Enter sync code field. It seems only there in the Onboarding page.

Steps to reproduce

  1. Go to Settings -> Syncing
  2. See the info and tips
  3. See that there is no field or button to enter the sync code or QR code

Expected behavior

There should be the equivalent oboarding screen on the Syncing page image

OR, if we only want that flow on the onboarding screen, we should change the text to specify that

Actual behavior

The text says we can pair from the settings, but we can't

Additional Information

jrainville commented 5 months ago

cc @noeliaSD I'm not sure what's the priority.

caybro commented 5 months ago

And @benjthayer what's the desired flow/design here

noeliaSD commented 4 months ago

cc: @xAlisher maybe you can share with us your thoughts!

xAlisher commented 3 months ago

It should be possible to scan code from mobile on desktop

IvanBelyakoff commented 3 months ago

For me the page is broken completely:

Screenshot 2024-07-18 at 12 35 36
caybro commented 3 months ago

For me the page is broken completely: Screenshot 2024-07-18 at 12 35 36

I can reproduce; let's fix this; the UI should not be broken at the very least

caybro commented 3 months ago

It should be possible to scan code from mobile on desktop

Scanning is possible; question is what to do with the "Enter sync code" part? IIRC there's no design for this outside of onboarding, so we either have to add the design and implement it, or we change the wording on this screen (last item Nr. 7):

image

CC @xAlisher your verdict? :)

caybro commented 2 months ago

ping @benjthayer as well

benjthayer commented 2 months ago

ping @benjthayer as well

Looks like we might be missing this button and the associated flow? https://www.figma.com/design/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?node-id=1592-128606&t=up6RhRz8iomYpAml-4

Screenshot 2024-08-08 at 09 37 56

Just cc'ing @igor-sirotin as I believe he did some work on this aspect of the app and may have some insights :)

igor-sirotin commented 2 months ago

The only supported flow to pair is through onboarding. AFAIK the backend simply doesn't support entering the sync code while already being logged into some account.

If the user already has same account on 2 devices (e.g. restored through seed phrase), they can go through Onboard with sync code flow and the account will become paired.

cc @Samyoul to confirm 🙏


P.S. I suppose we can adapt the code to support this flow, but this was never a priority. Meanwhile maybe we could adapt the instructions? There should anyway be some instructions about pairing a new device (which doesn't have the account yet).

cc @benjthayer @xAlisher