status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 78 forks source link

Token gating flag for Status Community #14671

Closed benjthayer closed 6 months ago

benjthayer commented 6 months ago

The Status community is a mix of token gated and open to public channels.

I believe we should only show the token gating if it is relevant to joining the community? So in the case of the Status community, we shouldn't show any token gating details top right of the card?

Screenshot 2024-05-09 at 17 05 57

Relevant flows: https://www.figma.com/file/qHfFm7C9LwtXpfdbxssCK3/Kuba%E2%8E%9CDesktop---Communities?type=design&node-id=2365-261989&mode=design&t=fBtpHEJlaNJGkl36-4

WDYT @John-44 ?

benjthayer commented 6 months ago

Also, we should probably consider a way for users to learn more about the token gating via the card - eg a tooltip on hover of the token gating tag (one for design to take on)

John-44 commented 6 months ago

@benjthayer correct, if a community doesn't have any "tokens required to become a member" permissions, then no tokens should be displayed on the card.

cc'ing @jrainville @iurimatias

caybro commented 6 months ago

This is a UI bug... we simply show this row of icons when we detect any permissions :/

visible: !!card.permissionsList && card.permissionsList.count > 0
caybro commented 6 months ago

I'll have a look at this

caybro commented 6 months ago

@benjthayer should we show the "lock" icon (without tokens) if the join permissions are private, or just hide it completely?