[EPIC][UI - Wallet Stability] Wallet `root store` and `shared store` improvements - Githubissues

status-im / status-desktop

Status Desktop client made in Nim & QML

https://status.app

Mozilla Public License 2.0

297 stars 79 forks source link

[EPIC][UI - Wallet Stability] Wallet `root store` and `shared store` improvements #14712

Open noeliaSD opened 6 months ago

noeliaSD commented 6 months ago

Description

There are some stores that are declared as Singletons. This fact introduce the following issues, among others:

It creates a dependency on context properties.
It breaks unit tests / storybook pages.
It makes the code more complex and has dificult maintenance.
Some components become copled and not isolated.

By following the approach agreed in here, work on updating these stores:

status-desktop/ui/app/AppLayouts/Wallet/stores/RootStore.qml
status-desktop/ui/imports/shared/stores/RootStore.qml

Tasks:

[x] https://github.com/status-im/status-desktop/issues/14801
[ ] https://github.com/status-im/status-desktop/issues/14802
[x] https://github.com/status-im/status-desktop/issues/14803
[ ] https://github.com/status-im/status-desktop/issues/14804
[x] https://github.com/status-im/status-desktop/issues/14805
TODO (the list is not complete)

noeliaSD commented 5 months ago

@micieslak please take a look at it and break it down if necessary!