search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
265 stars 76 forks source link

feat(@desktop/wallet): Add support for Account selection in Swap Modal using already existing AccountsModalHeader.qml #14838

Closed Khushboo-dev-cpp closed 4 days ago

Khushboo-dev-cpp commented 2 weeks ago

Closes #14749

feat(@desktop/wallet): Add support for Account selection in Swap Modal using already existing AccountsModalHeader.qml

What does the PR do

This PR introduced the new adaptor, store UI architecture which was discussed here https://miro.com/app/board/uXjVKS3chcc=/

Have also used this PR to start adding unit tests for the SwapModal only in relation to AccountSelection the based on the user story https://www.notion.so/Select-account-95fbef697ed84007b4450aec7f66b6cb?pvs=4

Implements this design https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap---Milestone-1?node-id=3410-278853&m=dev

Note that it is only using an adapted version of existing AccountsModalHeader.qml from SendModal and might be reworked refactored here https://github.com/status-im/status-desktop/issues/14786

Affected areas

SwapModal.qml

StatusQ checklist

Screenshot of functionality (including design for comparison)

https://github.com/status-im/status-desktop/assets/60327365/cfb85700-da9b-4c83-a50a-ff737470d05a

https://github.com/status-im/status-desktop/assets/60327365/60833093-fe47-4157-ae6a-6ae063c9da5c

status-im-auto commented 2 weeks ago

Jenkins Builds

Click to see older builds (43) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 8b258a74 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/1/) | 2024-05-16 21:30:25 | ~7 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-212248-8b258a-pr14838-aarch64.dmg) | | :heavy_check_mark: | 8b258a74 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/1/) | 2024-05-16 21:31:31 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/1//consoleText) | | :heavy_check_mark: | 8b258a74 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/1/) | 2024-05-16 21:33:58 | ~11 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-212251-8b258a-pr14838-x86_64.dmg) | | :heavy_check_mark: | 8b258a74 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/1/) | 2024-05-16 21:39:11 | ~16 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/1//consoleText) | | :heavy_check_mark: | 8b258a74 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/1/) | 2024-05-16 21:39:37 | ~16 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-212245-8b258a-pr14838-x86_64.tar.gz) | | | | | | | | | | :heavy_check_mark: | b5f93e62 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/2/) | 2024-05-16 21:50:33 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-214506-b5f93e-pr14838-aarch64.dmg) | | | | | | | | | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/3/) | 2024-05-16 21:57:41 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-215218-c5a403-pr14838-aarch64.dmg) | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/3/) | 2024-05-16 21:59:15 | ~6 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/3//consoleText) | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/3/) | 2024-05-16 22:02:40 | ~10 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-215218-c5a403-pr14838-x86_64.dmg) | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/3/) | 2024-05-16 22:04:13 | ~11 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/3//consoleText) | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/3/) | 2024-05-16 22:08:22 | ~16 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-215214-c5a403-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | c5a4031d | [#3](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/3/) | 2024-05-16 22:22:39 | ~30 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240516-215222-c5a403-pr14838-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/4/) | 2024-05-17 08:51:55 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-084600-cf867f-pr14838-aarch64.dmg) | | :heavy_check_mark: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/4/) | 2024-05-17 08:54:37 | ~8 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-084600-cf867f-pr14838-x86_64.dmg) | | :heavy_check_mark: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/4/) | 2024-05-17 08:55:12 | ~9 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/4//consoleText) | | :x: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/4/) | 2024-05-17 08:58:29 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/4/consoleText) | | :heavy_check_mark: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/4/) | 2024-05-17 09:05:12 | ~19 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-084555-cf867f-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | cf867faf | [#4](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/4/) | 2024-05-17 09:18:18 | ~32 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-084602-cf867f-pr14838-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/5/) | 2024-05-17 19:18:18 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-191222-9fb551-pr14838-aarch64.dmg) | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/5/) | 2024-05-17 19:20:27 | ~8 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-191223-9fb551-pr14838-x86_64.dmg) | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/5/) | 2024-05-17 19:22:36 | ~10 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/5//consoleText) | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/5/) | 2024-05-17 19:27:40 | ~15 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-191218-9fb551-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/5/) | 2024-05-17 19:30:23 | ~17 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/5//consoleText) | | :heavy_check_mark: | 9fb5513f | [#5](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/5/) | 2024-05-17 19:44:12 | ~31 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-191226-9fb551-pr14838-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/6/) | 2024-05-17 20:07:44 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-200220-5d0f27-pr14838-aarch64.dmg) | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/6/) | 2024-05-17 20:10:16 | ~7 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-200220-5d0f27-pr14838-x86_64.dmg) | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/6/) | 2024-05-17 20:11:01 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/6//consoleText) | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/6/) | 2024-05-17 20:17:41 | ~15 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-200215-5d0f27-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/6/) | 2024-05-17 20:18:06 | ~15 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/6//consoleText) | | :heavy_check_mark: | 5d0f274c | [#6](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/6/) | 2024-05-17 20:33:21 | ~30 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-200222-5d0f27-pr14838-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/7/) | 2024-05-17 21:00:20 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-205436-c89d57-pr14838-aarch64.dmg) | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/7/) | 2024-05-17 21:01:49 | ~7 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-205436-c89d57-pr14838-x86_64.dmg) | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/7/) | 2024-05-17 21:03:41 | ~9 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/7//consoleText) | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/7/) | 2024-05-17 21:09:40 | ~15 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-205431-c89d57-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/7/) | 2024-05-17 21:11:32 | ~16 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/7//consoleText) | | :heavy_check_mark: | c89d57d4 | [#7](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/7/) | 2024-05-17 21:28:12 | ~33 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240517-205437-c89d57-pr14838-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | ddc127e2 | [#8](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/8/) | 2024-05-27 10:50:50 | ~6 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240527-104427-ddc127-pr14838-aarch64.dmg) | | | | | | | | | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-14838/9/) | 2024-05-27 10:57:57 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240527-105237-78544c-pr14838-aarch64.dmg) | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/9/) | 2024-05-27 10:59:51 | ~7 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-14838/9//consoleText) | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-14838/9/) | 2024-05-27 11:01:40 | ~9 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240527-105237-78544c-pr14838-x86_64.dmg) | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/9/) | 2024-05-27 11:04:15 | ~11 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-14838/9//consoleText) | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-14838/9/) | 2024-05-27 11:10:48 | ~18 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240527-105233-78544c-pr14838-x86_64.tar.gz) | | :heavy_check_mark: | 78544c54 | [#9](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-14838/9/) | 2024-05-27 11:26:48 | ~34 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-240527-105238-78544c-pr14838-x86_64.exe) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:24:49 ~5 min macos/aarch64 :apple:dmg
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:27:30 ~8 min macos/x86_64 :apple:dmg
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:28:58 ~10 min tests/nim :page_facing_up:log
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:36:24 ~17 min tests/ui :page_facing_up:log
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:39:18 ~20 min linux/x86_64 :package:tgz
:heavy_check_mark: 3bdc675f #10 2024-05-28 07:49:05 ~30 min windows/x86_64 :cd:exe
:heavy_check_mark: 26030a85 #12 2024-05-28 08:21:22 ~6 min tests/nim :page_facing_up:log
:heavy_check_mark: 26030a85 #12 2024-05-28 08:22:31 ~7 min macos/aarch64 :apple:dmg
:heavy_check_mark: 26030a85 #12 2024-05-28 08:23:24 ~8 min macos/x86_64 :apple:dmg
:heavy_check_mark: 26030a85 #12 2024-05-28 08:26:38 ~11 min tests/ui :page_facing_up:log
:heavy_check_mark: 26030a85 #12 2024-05-28 08:34:32 ~19 min linux/x86_64 :package:tgz
:heavy_check_mark: 26030a85 #12 2024-05-28 08:49:39 ~34 min windows/x86_64 :cd:exe