search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
273 stars 76 forks source link

[UI - Wallet Stability] Remove `ManageTokensController` from stores #14945

Open micieslak opened 1 month ago

micieslak commented 1 month ago

Description

ManageTokensController is UI-side component and shouldn't be used within stores. It's against the assumption that stores are only thin layer exposing backend models/properties/methods. In practice it makes testing and using components in storybook problematic because stores are not available then.

When token management data is exposed via models: https://github.com/status-im/status-desktop/issues/14936 https://github.com/status-im/status-desktop/issues/14937

And main wallet's view are using them directly:

https://github.com/status-im/status-desktop/issues/14939 https://github.com/status-im/status-desktop/issues/14941

It should be easy to remove ManageTokensControllers from stores and keep them as dirty state management component locally within ManageTokensView.

noeliaSD commented 3 weeks ago

Next step for improving wallet but not enough capacity during this milestone