Closed Khushboo-dev-cpp closed 1 week ago
I'll take this and let's discuss it tomorrow :)
I'm removing the ui-team
label since @Khushboo-dev-cpp is taking it and it's easier to track ui capacity then!
can we keep it open for whoever has time to take it? as it is a bug? or maybe it doesn't work like that @noeliaSD ? and unassign me so that either me or Lukas can pick it up.
can we keep it open for whoever has time to take it? as it is a bug? or maybe it doesn't work like that @noeliaSD ? and unassign me so that either me or Lukas can pick it up.
Alright, added into our ui backlog then! Thank you!!
Screencast from 25.07.2024 13:31:16.webm
My findings recorded. Sometimes nothing is selected. Sometimes there is custom value but not applied and "Use default" button is not visible.
Another finding; this should not be marked as valid:
One more in SwapModal (after typing a custom value) and selecting "Use default" -> nothing is visually selected although the internal value is correct:
Reset after typing the default value (0.5) manually:
- https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap---Milestone-1?node-id=3410-267460&m=dev design shows a possibility to enter letters but we aren't allowing it at all
- Unable to enter values greater than 2 decimals points and showing error message
These won't be implemented simply because the internal validator doesn't let you enter values with more than 2 decimals or letters
Bug Report
Description
The SlippageSelector.qml is missing some behaviours and behaves incorrectly in some cases as listed below