Fleets: Single source of truth for fleet configuration (unitfy fleets.json and fleets.go) - Githubissues

status-im / status-desktop

Status Desktop client made in Nim & QML

https://status.app

Mozilla Public License 2.0

288 stars 78 forks source link

Fleets: Single source of truth for fleet configuration (unitfy fleets.json and fleets.go) #15030

Open friofry opened 4 months ago

friofry commented 4 months ago

We currently have inconsistent URLs in fleets.json and fleets.go, which leads to bugs,

see https://github.com/status-im/status-desktop/issues/14982#issuecomment-2140825418

3) The allMailServers model in the sync module is loaded from fleets.json (where nodeAdresses end in status.im). the fleet is shards.test:

fleets.json

"store-01.do-ams3.shards.test": "/dns4/store-01.do-ams3.shards.test.status.im/tcp/30303/p2p/16Uiu2HAmAUdrQ3uwzuE4Gy4D56hX6uLKEeerJAnhKEHZ3DxF1EfT",

fleets.go:
```
ID:      "store-01.do-ams3.shards.test",
Address: "/dns4/store-01.do-ams3.shards.test.statusim.net/tcp/30303/p2p/16Uiu2HAmAUdrQ3uwzuE4Gy4D56hX6uLKEeerJAnhKEHZ3DxF1EfT",
```
Description

Proposed solution:
1. Make fleets.json the source of truth for fleet configuration
2. Move fleets.json to the status-go repo (update desktop)
3. Read fleets.json and initialise configuration in fleets.go

friofry commented 4 months ago

udpate:

@jakubgs: You shouldn't be using fleets.json at all. We have DNS discovery with ENRTrees for a reason.

https://github.com/status-im/status-desktop/issues/14982#issuecomment-2151568402