search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
288 stars 78 forks source link

Mac TouchID is requested when password-only authentication is selected #15137

Closed friofry closed 2 months ago

friofry commented 3 months ago

Bug report

Description

TouchID authentication requested when user chooses not to use password authentication

Steps to reproduce

  1. Create a new account
  2. Select "I prefer to use my password" on the biometrics screen
  3. TouchID is requested
  4. Restart the application - TouchID will be requested

Expected behaviour

At steps 3,4 The application shouldn't request TouchID authentication.

Actual behaviour

TouchID authentication is prompted each time you log in

Additional Information

https://github.com/status-im/status-desktop/assets/1083341/17f8e8d0-9aca-4a11-82d5-dbecf43f041e

image

anastasiyaig commented 3 months ago

@friofry i logged https://github.com/status-im/status-desktop/issues/15123 the other day , perhaps it is related also, to clarify, are you running in Debug (with debug flag)? if yes, then it is caused by this flag on mac

jrainville commented 3 months ago

@friofry i logged #15123 the other day , perhaps it is related also, to clarify, are you running in Debug (with debug flag)? if yes, then it is caused by this flag on mac

They do seem related

friofry commented 3 months ago

@friofry i logged #15123 the other day , perhaps it is related also, to clarify, are you running in Debug (with debug flag)? if yes, then it is caused by this flag on mac

I've recompiled without INCLUDE_DEBUG_SYMBOLS (make clean; make update -j12; make run -j12), activated a new account. And the problem is still there

image
anastasiyaig commented 3 months ago

ya perhaps its dev build only, you could try with ci build , running it with --LOG_LEVEL = DEBUG and without this flag (running from command line)

friofry commented 3 months ago

On https://github.com/status-im/status-desktop/releases/tag/2.29.0-rc.11 the problem is reproduced both with and without --LOG_LEVEL=DEBUG

anastasiyaig commented 3 months ago

weird i did not see it :(

Cuteivist commented 3 months ago

I can confirm it still exists on master. Entering the password enables biometrics. After that disabling the biometrics doesn't popup the password request anymore.

Cuteivist commented 2 months ago

Additional note: It only happens for first account in data directory.