status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
296 stars 78 forks source link

Owner is not part of the channel list for encrypted communities #15145

Open jrainville opened 4 months ago

jrainville commented 4 months ago

Bug Report

Description

In normal channels, the owner is part normally, eg (see TheKeeper): image

However, on encrypted channels, the owner is not there (no TheKeeper): image

Tips

I'm 90% sure this is because of the status-go code. We populate the channel members during the member re-evaluation, and the owner doesn't re-evaluate himself I think.

Steps to reproduce

  1. Have a community with some encrypted channels and some unencrypted (no need for a permission to join)
  2. Check open channel -> Owner is there
  3. Check closed channel -> Owner is not there

Expected behavior

Owner is shown on all channels

Actual behavior

Owner is only present is open channels

Additional Information

igor-sirotin commented 4 months ago

hmmm, can't reproduce so far 🤔

I also tried with a status-go test, the owner is in the encrypted channel members on both sides: I tired manually with status-desktop, it gives the same result:

Owner:

image

User:

image

I'm using 2.29.0 for the owner. And latest master 5c1e800f14e246dcab82cfcfad759ba27ec99be1 for the user.

At the same time I can confirm I see this in the Status Community 🤔

igor-sirotin commented 4 months ago

Hmm, could be that in my case the owner actually satisfies the channel permission. Let me check. Though it's not the case for status-go test.

jrainville commented 4 months ago

Hmm, could be that in my case the owner actually satisfies the channel permission. Let me check. Though it's not the case for status-go test.

Ah that's a good clue.

I just checked and I see TheKeeper in #test-leads, but not in the QA channel for example

igor-sirotin commented 4 months ago

Still couldn't reproduce. I tried different channel permissions, that only the user matches, but not the owner:

In all cases both owner and the user appear in the members list.

jrainville commented 4 months ago

Weird. @igor-sirotin do you also see the same as me in the Status Community though? TheKeeper is not part of all channels

igor-sirotin commented 4 months ago

do you also see the same as me in the Status Community though? TheKeeper is not part of all channels

@jrainville yep, I can confirm this.

igor-sirotin commented 4 months ago

Got a confirmation that in the described case TheKeeper doesn't see himself in the memebrs list as well.

jrainville commented 4 months ago

If you still can't reproduce or find a clue in the code Monday, we can move this to another milestone