search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
271 stars 76 forks source link

Logs in UTC time #15198

Open chair28980 opened 2 weeks ago

chair28980 commented 2 weeks ago

Proposing switching logs to use UTC time, this would simplify the debugging process by providing a consistent time reference.

richard-ramos commented 1 week ago

:-O i did not realize this task had already been assigned to @igor-sirotin Sorry!

chair28980 commented 1 week ago

Fixed by https://github.com/status-im/go-ethereum/pull/108

igor-sirotin commented 1 week ago

@jrainville I looked at the logs of the app we write from Nim. Local time is used there, not UTC.

But it seems that we don't really have control over this. nim-chronicles provide option to change the format of the timestamps (RFC 3339, Unix, None): https://github.com/status-im/nim-chronicles/blob/33761a5f77610d3f87f774244490eae43a9ac5a1/README.md?plain=1#L376-L397

But it's always local time, this can be seen with usage of now() here: https://github.com/status-im/nim-chronicles/blob/ccbb7566d1a06bfc1ec42dd8da74a47f1d3b3f4b/chronicles/log_output.nim#L425-L427

I don't think it's very important to have UTC in application logs, so far it was never a problem. It will be our of sync now with geth.log, but I guess we can live with that?

fryorcraken commented 1 week ago

I'd suggest UTC across all logs as we need to be able to correlate app events to Waku events. More intense debugging means it's a problem now.

igor-sirotin commented 1 week ago

@jrainville should we mark this as blocked or smth? I didn't investigate, but don't see a simple workaround until https://github.com/status-im/nim-chronicles/issues/151 is implemented.