Closed noeliaSD closed 3 months ago
Oh that's a new one! I like it, would definitely be a better replacement for the SwapModal/SwapInputPanel component
Just a reminder, this is also used in SwapModal like this: AmountToSend -> SwapInputPanel -> SwapModal
As decided in our sync, maybe better to create a separate and new component, only apply this new component to send and bridge AND create a separate task to do the integration of the new component to swap for the next milestone.
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)
We don't really use a double here (but the rawValue
based on the Big
number) in SwapModal
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)
We don't really use a double here (but the
rawValue
based on theBig
number) in SwapModal
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)
We don't really use a double here (but the
rawValue
based on theBig
number) in SwapModal
Yes, but in SwapModal we use the "text" for display, and rawValue
when sending the transaction right?
But general yeah, there should be ideally no floats/doubles around in that code
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)
We don't really use a double here (but the
rawValue
based on theBig
number) in SwapModalYes, but in SwapModal we use the "text" for display, and
rawValue
when sending the transaction right?But general yeah, there should be ideally no floats/doubles around in that code
The thing is that these floats are used to calculate the rawValue in the end and thats whats causing the issue withe losing precision.
Design
AmountToSend
andAmountToReceive
(maybe we can do the replacement here or keep the integration for task https://github.com/status-im/status-desktop/issues/15215)