search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
278 stars 77 forks source link

Group chat icon symbols have a discrepancy with mobile #15230

Open churik opened 1 month ago

churik commented 1 month ago

Bug Report

Description

According to design mobile group chat icon looks like : IMAGE 2024-06-18 11:48:13

On desktop it is shown as 2-letters: Status Desktop 2024-06-18 11-50-51

Steps to reproduce

  1. Create a group chat with no photo and compare icons on desktop and mobile

Expected behavior

as per design (matches mobile) Link to design: https://www.figma.com/design/IBmFKgGL1B4GzqD8LQTw6n/Design-System-for-Desktop%2FWeb?node-id=14584-169312&t=2k2qvjLmTblJMAGq-4

Actual behavior

shown similarly to 1-1 chats

Additional Information

caybro commented 1 month ago

CC @noeliaSD seems like a rather easy fix

jrainville commented 1 month ago

We are still on old designs, so I don't know if it makes sense to match on certain areas and not others. We can loop @benjthayer on it.

noeliaSD commented 1 month ago

Maybe @xAlisher can also answer while Ben is not available!

noeliaSD commented 1 month ago

I add it to the milestone but low priority!

churik commented 1 month ago

@caybro also it is a regression from the fix for 1-1 chat https://github.com/status-im/status-desktop/issues/14667 as far as I understand

caybro commented 3 weeks ago

@churik so if I have 10 group chats, they should all have the same icon?

caybro commented 3 weeks ago

Ping @xAlisher: should we follow mobile design here, or stay as-is (2 letter identicons for group chats)?

noeliaSD commented 2 weeks ago

There are still some details to be confiremed. Moved to next milestone bc of team capacity.