search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
271 stars 76 forks source link

Members get kick AC notifications after the ownership change #15341

Open mprakhov opened 1 week ago

mprakhov commented 1 week ago

Bug Report

Description

When ownership changes, all members get a kick notification

Steps to reproduce

  1. Create a community and mint owner token
  2. Have at least 2 members A and B
  3. Transfer ownership token to member A

Expected behavior

Members did not get kick AC notification on ownership change

Actual behavior

Member B got AC notification, that he was kicked

image

Additional Information

86doteth commented 4 days ago

btw there werent any ownership changes in these two instances. a week ago i tried transferring control node between two devices, both the same account. that combined with the displayname bug i still had probably led to the mass kick. after i got the pr fix for that and put my pre-kick data folder back all members were back again. but in the week since it seems a few members like @jrainville and maybe you as well got removed/kicked a few times. some of these kicks might be triggered by me restarting status, i noticed a user monora basically got removed every time (5-6 times now?) after i logged in. and then every time i received a join request by them maybe an hour later or so.

mprakhov commented 4 days ago

Thank you for the update! Looking for a root cause

mprakhov commented 4 days ago

Reproduced the kick.

  1. Restored account by a seed phrase
  2. Mark self as a control node
  3. Restart the app
  4. Reevaluation on restart starts
  5. Member kicked

After restoring by a seed phrase, we don't have members RevealedAccounts, so all members are kicked due to absent wallet information

The issue will be actual during switching control node device for non synced device

86doteth commented 4 days ago

nice! i did restore my current profile from seed but like months back i think v2.27. not sure the problem existed before a week ago and why only the same few members seem to get kicked over and over again 🤔

edit: actually on second thought i have been rebooting my install much more often in the past week due to running in a vm while before when i had my main pc available i would just keep it running for weeks at a time so maybe thats why i havent noticed the problem before?