status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

Airdrop token to community members closes after TouchID authentication #15428

Open vrnvrn opened 2 months ago

vrnvrn commented 2 months ago

Bug Report

Description

Airdrop token to community members crashes after signing transaction. Possibly related to Issue 15383 but user not closing authentication popup

Video blurred :10-:34 to protect identities of community members:

https://github.com/status-im/status-desktop/assets/134992593/9c703ecf-7f93-4f41-978f-c6f65e91517d

Steps to reproduce

New airdrop Select community members Select address with enough gas to sign transaction Select sign transaction Use TouchID or password to authenticate

Expected behavior

After airdrop transaction is signed, there should be a popup to indicate it is in progress with a link to Etherscan.

Actual behavior

After airdrop transaction is signed, application returns to default Airdrop tab page. Transaction not found on Etherscan nor do wallets receive token.

Additional Information

jrainville commented 2 months ago

It's probably a good idea to base on top of https://github.com/status-im/status-desktop/pull/15385

endulab commented 2 months ago

Tested on master. The behaviour is correct. I noticed on the movie that there is no toast message after authentication ("Airdrop in progress. View in Etherscan"). This is really strange. @vschrenk anything in logs?

UPDATE I also tested our release branch (2.28.x). I airdropped to 2 community members and it was ok. @vschrenk you wrote in the description "crashes". Did you mean "closes", like in the title? I do not see the crash on the movie.

vrnvrn commented 2 months ago

@endulab I'm sorry, close is the correct term - @jrainville updated the title for me.

I just tried again, now on this build. Same issue, and here is the log: app_20240705_195144.log

endulab commented 2 months ago

@endulab I'm sorry, close is the correct term - @jrainville updated the title for me.

I just tried again, now on this build. Same issue, and here is the log: app_20240705_195144.log

Thank you @vschrenk for logs. Indeed, I see some errors there. It is hard for me to understand what is going on because if there is an error during estimations, the UI should block the whole process. In logs I see the error during estimations and another one during airdrop (which does not make sense). On the movie I see that estimation is displayed and you can authenticate airdrop. Are you sure that the log is the correct one?

Also, can you give me some more context about what are you doing? Did you have any other problems with token related operations? I guess that minting went well, right? Did you try to authenticate w/o touch id?

If you are ok with this, I can prepare a special branch for you with a lot of logs during airdrop process, so we can investigate step by step what is going on.

vrnvrn commented 2 months ago

Minting went well, airdrops worked without issue multiple times until this started, and hasn't worked ever since. I just tried again, currently on this build. Logs too large to upload here, shared here.

Yes, happy to investigate step by step! This is not the only issue I'm having.

endulab commented 1 month ago

@vschrenk thank you for your cooperation. I created a pr with additional logs and also some potential fixes regarding computing fees. We also suspect problems with transaction data.

Before trying the app, please backup your Status data folder. Also please remove all Status/data/geth logs and Status/logs/app* files. Then run the app and try to airdrop one time. Then close the app and share logs.