search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

Swap - Pay and Receive assets get unselected, Pay amount resets to 0 #15525

Closed virginiabalducci closed 2 months ago

virginiabalducci commented 2 months ago

Bug Report

Description

While user is setting up a Swap transaction, there is an issue that shows up that deletes the selected Pay and Receive Tokens, and the amount on Pay resets to cero. This is a hard to reproduce issue that I have been experiencing frequently. I describe below one possible way to reproduce it

Steps to reproduce

  1. Select an asset for Pay and receive (I left SNT as receive)
  2. leave the pop up open and see that the calculation updates a couple of times
  3. Eventually, both Pay and Receive will default to "Select asset"

Expected behavior

Pay and Receive selected assets to remain seleced Pay amount to remain as user has selected.

Actual behavior

Pay and Receive selected assets are reset and the "Select asset" button displays on both sides. Pay amount resets to cero.

Refer to these screen recordings:

https://github.com/status-im/status-desktop/assets/68916150/c95aaf6e-29fc-4a6e-a7d9-f8ee352132b6

https://drive.google.com/file/d/1DiyD5AX1wVfCpLssAQS6Zd9Euj1ne8K1/view?usp=sharing

Additional Information

Console log

ERR 2024-07-10 11:41:59.204-03:00 qt error                                   topics="qt" tid=19143421 text="\ncmp (qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:149)\nisFormFilledCorrectly (qrc:/app/AppLayouts/Wallet/popups/swap/SwapInputParamsForm.qml:60)\nfetchSuggestedRoutes (qrc:/app/AppLayouts/Wallet/popups/swap/SwapModal.qml:47)\nonTriggered (qrc:/app/AppLayouts/Wallet/popups/swap/SwapModal.qml:43)" file=qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:149 category=default
ERR 2024-07-10 11:42:00.212-03:00 qt error                                   topics="qt" tid=19143421 text="\ncmp (qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:149)\nisFormFilledCorrectly (qrc:/app/AppLayouts/Wallet/popups/swap/SwapInputParamsForm.qml:60)\nfetchSuggestedRoutes (qrc:/app/AppLayouts/Wallet/popups/swap/SwapModalAdaptor.qml:253)\n (qrc:/app/AppLayouts/Wallet/popups/swap/SwapModal.qml:36)\n (qrc:/imports/utils/Backpressure/Backpressure.qml:126)\n (qrc:/imports/utils/Backpressure/Backpressure.qml:28)" file=qrc:/StatusQ/Core/Utils/AmountsArithmetic.qml:149 category=default
DBG 2024-07-10 11:42:00.213-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143421 file=core.nim:27 rpc_method=wallet_getSuggestedRoutesV2Async
DBG 2024-07-10 11:42:07.140-03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=19143528 file=threadpool.nim:56 messageType=FetchTokensMarketValuesTaskArg:ObjectType threadid=19143528 task="{\"$type\":\"FetchTokensMarketValuesTaskArg:ObjectType\",\"symbols\":[\"ZRX\",\"1INCH\",\"ABYSS\",\"AIOZ\",\"API3\",\"ARPA\",\"ASH\",\"AAVE\",\"aUSDC\",\"GHST\",\"AGLD\",\"AERGO\",\"AE\",\"AST\",\"AKRO\",\"ALCX\",\"ACH\",\"ALEPH\",\"ALI\",\"TLM\",\"ALPHA\",\"AMB\",\"ADX\",\"AMP\",\"AMPL\",\"FORTH\",\"ANKR\",\"APE\",\"APPC\",\"ANT\",\"ARB\",\"ABT\",\"AVT\",\"ASM\",\"ATM\",\"AUDIO\",\"ATA\",\"AXL\",\"AXS\",\"BNB\",\"BTU\",\"BADGER\",\"BAL\",\"BNT\",\"BAND\",\"BOND\",\"BAT\",\"BRLN\",\"BICO\",\"BUSD\",\"BIT\",\"CSNO\",\"BLT\",\"BLUR\",\"BLZ\",\"BOBA\",\"AUCTION\",\"BTRST\",\"BTM\",\"CELO\",\"COTI\",\"CTSI\",\"CELR\",\"Centra\",\"XCN\",\"Link\",\"LINK\",\"CHZ\",\"CHR\",\"TIME\",\"CND\",\"COVAL\",\"CVC\",\"CLV\",\"COB\",\"CFI\",\"C98\",\"CDT\",\"cbETH\",\"COMP\",\"cDAI\",\"CVX\",\"CQT\",\"CRO\",\"CRPT\",\"CTX\",\"CRV\",\"GEN\",\"YFII\",\"DIA\",\"ROL\",\"DAI\",\"DTA\",\"DAT\",\"DPI\",\"DYP\",\"MANA\",\"USDD\",\"HST\",\"DPY\",\"DLT\",\"DENT\",\"DCN\",\"DDX\",\"DEXT\",\"DGD\",\"DGX\",\"ELON\",\"DRT\",\"DREP\",\"ELF\",\"EOS\",\"ETH2x-FLI\",\"EKO\",\"EDG\",\"EDO\",\"ELA\",\"ENG\",\"ENJ\",\"LEND\",\"ETH\",\"ENS\",\"ERN\",\"EUL\",\"EUROC\",\"EVX\",\"FTM\",\"FET\",\"1ST\",\"FXC\",\"FORT\",\"FRAX\",\"FXS\",\"FUEL\",\"FUN\",\"FX\",\"GMX\",\"GRID\",\"GYEN\",\"GALA\",\"GUSD\",\"MV\",\"JAM\",\"GTC\",\"GNO\",\"GODS\",\"GFI\",\"GLM\",\"GNT\",\"HOPR\",\"FARM\",\"HFT\",\"HEZ\",\"HIGH\",\"HOP\",\"HT\",\"ICN\",\"ICOS\",\"IDEX\",\"IOST\",\"ILV\",\"IMX\",\"INDEX\",\"INJ\",\"INV\",\"IOTX\",\"JASMY\",\"JUP\",\"KRL\",\"KEEP\",\"KP3R\",\"KIN\",\"KNC\",\"LCX\",\"LOKA\",\"LDO\",\"LQTY\",\"LUSD\",\"LPT\",\"LOOM\",\"LRC\",\"MATH\",\"MXC\",\"MIM\",\"MAGIC\",\"MKR\",\"MPL\",\"POND\",\"MASK\",\"MDT\",\"MLN\",\"MC\",\"MTL\",\"METIS\",\"MET\",\"DAR\",\"MIR\",\"MGO\",\"MOD\",\"MDA\",\"MCO\",\"MONA\",\"MTH\",\"TKN\",\"MCO2\",\"MOC\",\"MULTI\",\"MUSE\",\"ALICE\",\"NKN\",\"NEST\",\"NEXO\",\"NU\",\"NMR\",\"OMG\",\"ORCA\",\"OCEAN\",\"OTN\",\"OP\",\"OXT\",\"OGN\",\"TRAC\",\"ORN\",\"PRQ\",\"PAXG\",\"PLR\",\"PRG\",\"UPI\",\"USDP\",\"PYUSD\",\"PPP\",\"PAX\",\"PEPE\",\"PERP\",\"PLA\",\"PLU\",\"POE\",\"POLS\",\"NCT\",\"MATIC\",\"POLY\",\"PPT\",\"PT\",\"POWR\",\"PRIME\",\"GAL\",\"PRO\",\"NPXS\",\"QRL\",\"QRDO\",\"QNT\",\"QSP\",\"QKC\",\"QUICK\",\"R\",\"RAE\",\"REVV\",\"RHOC\",\"XRL\",\"RAD\",\"RAI\",\"RDN\",\"RLY\",\"RGT\",\"RARI\",\"RNDR\",\"REN\",\"REP\",\"REPv2\",\"REQ\",\"RBN\",\"RCN\",\"rETH\",\"ROOK\",\"RBC\",\"SAN\",\"UPP\",\"SKL\",\"SOL\",\"SNM\",\"SPANK\",\"SUKU\",\"SWFTC\",\"SAI\",\"SALT\",\"SPN\",\"KEY\",\"FOX\",\"SHIB\",\"SHPING\",\"ST\",\"SNGLS\",\"SLP\",\"CUBE\",\"SPELL\",\"SPIKE\",\"USDS\",\"FIS\",\"STG\",\"SNT\",\"STT\",\"STORJ\",\"STORM\",\"STX\",\"XDATA\",\"SUB\",\"SUPER\",\"RARE\",\"SUSHI\",\"SXP\",\"SYLO\",\"SYN\",\"MFG\",\"sUSD\",\"SNX\",\"TONE\",\"TGT\",\"TRB\",\"PAY\",\"USDT\",\"GRT\",\"SAND\",\"TVK\",\"T\",\"TNT\",\"TOKE\",\"TAAS\",\"TRIBE\",\"TRX\",\"TAUD\",\"TCAD\",\"TRU\",\"TGBP\",\"TUSD\",\"TRST\",\"UMA\",\"USDC\",\"USDC.e\",\"UBT\",\"UNFI\",\"UKG\",\"SOCKS\",\"UNI\",\"UBI\",\"VERI\",\"VRS\",\"VIB\",\"VGX\",\"WEENUS\",\"WETH9\",\"WINGS\",\"WOO\",\"WaBi\",\"WTC\",\"WAMPL\",\"WBTC\",\"WCFG\",\"WETH\",\"XEENUS\",\"XPA\",\"XSGD\",\"XYO\",\"XAUR\",\"YEENUS\",\"YGG\",\"ZEENUS\",\"ZSC\",\"agEUR\",\"DYDX\",\"DNT\",\"RLC\",\"MUSD\",\"PSTAKE\",\"tBTC\",\"YFI\"],\"currency\":\"USD\",\"vptr\":105553143694304,\"slot\":\"tokensMarketValuesRetrieved\"}"
DBG 2024-07-10 11:42:07.142-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143528 file=core.nim:27 rpc_method=wallet_fetchMarketValues
DBG 2024-07-10 11:42:07.236-03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=19143526 file=threadpool.nim:56 messageType=FetchTokensPricesTaskArg:ObjectType threadid=19143526 task="{\"$type\":\"FetchTokensPricesTaskArg:ObjectType\",\"symbols\":[\"ZRX\",\"1INCH\",\"ABYSS\",\"AIOZ\",\"API3\",\"ARPA\",\"ASH\",\"AAVE\",\"aUSDC\",\"GHST\",\"AGLD\",\"AERGO\",\"AE\",\"AST\",\"AKRO\",\"ALCX\",\"ACH\",\"ALEPH\",\"ALI\",\"TLM\",\"ALPHA\",\"AMB\",\"ADX\",\"AMP\",\"AMPL\",\"FORTH\",\"ANKR\",\"APE\",\"APPC\",\"ANT\",\"ARB\",\"ABT\",\"AVT\",\"ASM\",\"ATM\",\"AUDIO\",\"ATA\",\"AXL\",\"AXS\",\"BNB\",\"BTU\",\"BADGER\",\"BAL\",\"BNT\",\"BAND\",\"BOND\",\"BAT\",\"BRLN\",\"BICO\",\"BUSD\",\"BIT\",\"CSNO\",\"BLT\",\"BLUR\",\"BLZ\",\"BOBA\",\"AUCTION\",\"BTRST\",\"BTM\",\"CELO\",\"COTI\",\"CTSI\",\"CELR\",\"Centra\",\"XCN\",\"Link\",\"LINK\",\"CHZ\",\"CHR\",\"TIME\",\"CND\",\"COVAL\",\"CVC\",\"CLV\",\"COB\",\"CFI\",\"C98\",\"CDT\",\"cbETH\",\"COMP\",\"cDAI\",\"CVX\",\"CQT\",\"CRO\",\"CRPT\",\"CTX\",\"CRV\",\"GEN\",\"YFII\",\"DIA\",\"ROL\",\"DAI\",\"DTA\",\"DAT\",\"DPI\",\"DYP\",\"MANA\",\"USDD\",\"HST\",\"DPY\",\"DLT\",\"DENT\",\"DCN\",\"DDX\",\"DEXT\",\"DGD\",\"DGX\",\"ELON\",\"DRT\",\"DREP\",\"ELF\",\"EOS\",\"ETH2x-FLI\",\"EKO\",\"EDG\",\"EDO\",\"ELA\",\"ENG\",\"ENJ\",\"LEND\",\"ETH\",\"ENS\",\"ERN\",\"EUL\",\"EUROC\",\"EVX\",\"FTM\",\"FET\",\"1ST\",\"FXC\",\"FORT\",\"FRAX\",\"FXS\",\"FUEL\",\"FUN\",\"FX\",\"GMX\",\"GRID\",\"GYEN\",\"GALA\",\"GUSD\",\"MV\",\"JAM\",\"GTC\",\"GNO\",\"GODS\",\"GFI\",\"GLM\",\"GNT\",\"HOPR\",\"FARM\",\"HFT\",\"HEZ\",\"HIGH\",\"HOP\",\"HT\",\"ICN\",\"ICOS\",\"IDEX\",\"IOST\",\"ILV\",\"IMX\",\"INDEX\",\"INJ\",\"INV\",\"IOTX\",\"JASMY\",\"JUP\",\"KRL\",\"KEEP\",\"KP3R\",\"KIN\",\"KNC\",\"LCX\",\"LOKA\",\"LDO\",\"LQTY\",\"LUSD\",\"LPT\",\"LOOM\",\"LRC\",\"MATH\",\"MXC\",\"MIM\",\"MAGIC\",\"MKR\",\"MPL\",\"POND\",\"MASK\",\"MDT\",\"MLN\",\"MC\",\"MTL\",\"METIS\",\"MET\",\"DAR\",\"MIR\",\"MGO\",\"MOD\",\"MDA\",\"MCO\",\"MONA\",\"MTH\",\"TKN\",\"MCO2\",\"MOC\",\"MULTI\",\"MUSE\",\"ALICE\",\"NKN\",\"NEST\",\"NEXO\",\"NU\",\"NMR\",\"OMG\",\"ORCA\",\"OCEAN\",\"OTN\",\"OP\",\"OXT\",\"OGN\",\"TRAC\",\"ORN\",\"PRQ\",\"PAXG\",\"PLR\",\"PRG\",\"UPI\",\"USDP\",\"PYUSD\",\"PPP\",\"PAX\",\"PEPE\",\"PERP\",\"PLA\",\"PLU\",\"POE\",\"POLS\",\"NCT\",\"MATIC\",\"POLY\",\"PPT\",\"PT\",\"POWR\",\"PRIME\",\"GAL\",\"PRO\",\"NPXS\",\"QRL\",\"QRDO\",\"QNT\",\"QSP\",\"QKC\",\"QUICK\",\"R\",\"RAE\",\"REVV\",\"RHOC\",\"XRL\",\"RAD\",\"RAI\",\"RDN\",\"RLY\",\"RGT\",\"RARI\",\"RNDR\",\"REN\",\"REP\",\"REPv2\",\"REQ\",\"RBN\",\"RCN\",\"rETH\",\"ROOK\",\"RBC\",\"SAN\",\"UPP\",\"SKL\",\"SOL\",\"SNM\",\"SPANK\",\"SUKU\",\"SWFTC\",\"SAI\",\"SALT\",\"SPN\",\"KEY\",\"FOX\",\"SHIB\",\"SHPING\",\"ST\",\"SNGLS\",\"SLP\",\"CUBE\",\"SPELL\",\"SPIKE\",\"USDS\",\"FIS\",\"STG\",\"SNT\",\"STT\",\"STORJ\",\"STORM\",\"STX\",\"XDATA\",\"SUB\",\"SUPER\",\"RARE\",\"SUSHI\",\"SXP\",\"SYLO\",\"SYN\",\"MFG\",\"sUSD\",\"SNX\",\"TONE\",\"TGT\",\"TRB\",\"PAY\",\"USDT\",\"GRT\",\"SAND\",\"TVK\",\"T\",\"TNT\",\"TOKE\",\"TAAS\",\"TRIBE\",\"TRX\",\"TAUD\",\"TCAD\",\"TRU\",\"TGBP\",\"TUSD\",\"TRST\",\"UMA\",\"USDC\",\"USDC.e\",\"UBT\",\"UNFI\",\"UKG\",\"SOCKS\",\"UNI\",\"UBI\",\"VERI\",\"VRS\",\"VIB\",\"VGX\",\"WEENUS\",\"WETH9\",\"WINGS\",\"WOO\",\"WaBi\",\"WTC\",\"WAMPL\",\"WBTC\",\"WCFG\",\"WETH\",\"XEENUS\",\"XPA\",\"XSGD\",\"XYO\",\"XAUR\",\"YEENUS\",\"YGG\",\"ZEENUS\",\"ZSC\",\"agEUR\",\"DYDX\",\"DNT\",\"RLC\",\"MUSD\",\"PSTAKE\",\"tBTC\",\"YFI\"],\"currencies\":[\"USD\"],\"vptr\":105553143694304,\"slot\":\"tokensPricesRetrieved\"}"
DBG 2024-07-10 11:42:07.237-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143526 file=core.nim:27 rpc_method=wallet_fetchPrices
DBG 2024-07-10 11:42:07.278-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143421 file=core.nim:27 rpc_method=wallet_checkRecentHistoryForChainIDs
DBG 2024-07-10 11:42:07.278-03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=19143522 file=threadpool.nim:56 messageType=BuildTokensTaskArg:ObjectType threadid=19143522 task="{\"$type\":\"BuildTokensTaskArg:ObjectType\",\"accounts\":[\"0x139dfa74587e079b21b991ddb3d0a33677029310\",\"0x69a4f3ebdeb18d5783848c2558136718837f36bc\"],\"storeResult\":true,\"vptr\":105553143694400,\"slot\":\"onAllTokensBuilt\"}"
DBG 2024-07-10 11:42:07.278-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143522 file=core.nim:27 rpc_method=wallet_fetchOrGetCachedWalletBalances
WRN 2024-07-10 11:42:07.307-03:00 qt warning                                 topics="qt" tid=19143421 text="TokenSelector::selectToken: unknown tokensKey: DAI" file=qrc:/app/AppLayouts/Wallet/controls/TokenSelector.qml:41 category=qml
WRN 2024-07-10 11:42:07.308-03:00 qt warning                                 topics="qt" tid=19143421 text="TokenSelector::selectToken: unknown tokensKey: USDT" file=qrc:/app/AppLayouts/Wallet/controls/TokenSelector.qml:41 category=qml
WRN 2024-07-10 11:42:07.356-03:00 qt warning                                 topics="qt" tid=19143421 text="TokenSelector::selectToken: unknown tokensKey: " file=qrc:/app/AppLayouts/Wallet/controls/TokenSelector.qml:41 category=qml
WRN 2024-07-10 11:42:07.357-03:00 qt warning                                 topics="qt" tid=19143421 text="TokenSelector::selectToken: unknown tokensKey: " file=qrc:/app/AppLayouts/Wallet/controls/TokenSelector.qml:41 category=qml
DBG 2024-07-10 11:42:10.042-03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=19143529 file=threadpool.nim:56 messageType=BuildTokensTaskArg:ObjectType threadid=19143529 task="{\"$type\":\"BuildTokensTaskArg:ObjectType\",\"accounts\":[\"0x139dfa74587e079b21b991ddb3d0a33677029310\",\"0x69a4f3ebdeb18d5783848c2558136718837f36bc\"],\"storeResult\":true,\"vptr\":105553143694400,\"slot\":\"onAllTokensBuilt\"}"
DBG 2024-07-10 11:42:10.043-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143529 file=core.nim:27 rpc_method=wallet_fetchOrGetCachedWalletBalances
DBG 2024-07-10 11:42:15.549-03:00 [threadpool task thread] initiating task   topics="task-threadpool" tid=19143520 file=threadpool.nim:56 messageType=BuildTokensTaskArg:ObjectType threadid=19143520 task="{\"$type\":\"BuildTokensTaskArg:ObjectType\",\"accounts\":[\"0x139dfa74587e079b21b991ddb3d0a33677029310\",\"0x69a4f3ebdeb18d5783848c2558136718837f36bc\"],\"storeResult\":true,\"vptr\":105553143694400,\"slot\":\"onAllTokensBuilt\"}"
DBG 2024-07-10 11:42:15.550-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143520 file=core.nim:27 rpc_method=wallet_fetchOrGetCachedWalletBalances
DBG 2024-07-10 11:42:18.697-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143421 file=core.nim:27 rpc_method=wakuext_speedupArchivesImport
DBG 2024-07-10 11:43:17.878-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=19143421 file=core.nim:27 rpc_method=wakuext_slowdownArchivesImport
virginiabalducci commented 2 months ago

This is also reproducible when selecting "Sign" and wait for some minutes until the fees stop being calculated Screenshot 2024-07-10 at 3 52 01 PM

anastasiyaig commented 2 months ago

i was able to reproduce this issue as well today, the Pay amount is reset when Receive is not

Screenshot 2024-07-11 at 14 30 04