status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
286 stars 78 forks source link

dApp - sd-6 - dApp name not always displayed in connection list #15593

Closed glitchminer closed 1 month ago

glitchminer commented 1 month ago

Bug Report

Description

dApp name is not always shown

image

Steps to reproduce

Connect to yearn.fi, view dapp list

Expected behavior

Name displayed in dapp list item

Additional Information

clauxx commented 1 month ago

Seems like the provider doesn't "provide" any useful visual metadata

:metadata {:name "", :description "", :url "https://yearn.fi/", :icons []}

I guess if there is no name, we should format the url as the name, like: "yearn.fi" could be the name in this case.a

clauxx commented 1 month ago

@qoqobolo I guess this would be the case on mobile as well.

qoqobolo commented 1 month ago

@qoqobolo I guess this would be the case on mobile as well.

Yep, name is not displayed for this particular dapp

Screenshot 2024-07-18 at 11 15 50

Can I add this issue to https://github.com/status-im/status-mobile/issues/20769 or is it a separate problem? We will also double check the other dapps to see if the name is displayed.

clauxx commented 1 month ago

@qoqobolo I guess this would be the case on mobile as well.

Yep, name is not displayed for this particular dapp

Screenshot 2024-07-18 at 11 15 50

Can I add this issue to status-im/status-mobile#20769 or is it a separate problem? We will also double check the other dapps to see if the name is displayed.

Yeah, can add it there as well 👍. I think the only other edge case could be that the dapp didn't define any of the following: name, description, url. In this case we could show some placeholder, like "Unknown" or smth? cc: @xAlisher

xAlisher commented 1 month ago

@qoqobolo @clauxx

In case name and picture missing I'll suggest to use URL instead if Title and use Wallet User avatar component to generate icon.

image

https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=114-7646&t=z70ji8Dxuvm80yAe-1