search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
287 stars 78 forks source link

dApps - Can't sign a message from Uniswap #15946

Closed anastasiyaig closed 4 days ago

anastasiyaig commented 1 month ago

Bug Report

Description

Signing message from uniswap gets me to rejected state

Steps to reproduce

https://github.com/user-attachments/assets/715f173e-3b22-42c4-8d1a-c2369d04886f

Actual behavior

ERR 2024-08-01 07:14:49.835+03:00 rpc response error                         topics="rpc" tid=27431383 file=core.nim:36 err="\nstatus-go error [methodName:wallet_safeSignTypedDataForDApps, code:-32000, message:unknown type \"uint160\" ]\n"
ERR 2024-08-01 07:14:49.835+03:00 error doing rpc request                    topics="rpc" tid=27431383 file=core.nim:39 methodName=wallet_safeSignTypedDataForDApps exception="\nstatus-go error [methodName:wallet_safeSignTypedDataForDApps, code:-32000, message:unknown type \"uint160\" ]\n"
DBG 2024-08-01 07:14:49.835+03:00 qt message

Additional Information

clauxx commented 1 month ago

Seems like this issue is caused by the old version of geth on status-go, which doesn't include all solidity types for typed data, which are supposed to be included based on EIP-712. Hence, requests that include e.g. uint160, uint48, etc. in the types are considered invalid for now. The issue seems fixed on go-ethereum master, where they support all types necessary.

Can be moved to 2.31 for now, as we definitely cannot fix it in 2.30.

alexjba commented 4 days ago

Closed by https://github.com/status-im/status-go/pull/5755