search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
288 stars 78 forks source link

[Browser plugin connector] Follow-up fixes on Connected DApps display #16026

Open kounkou opened 1 month ago

kounkou commented 1 month ago

Description

In ticket, we added the feature to display the list of connected DApps. And @felicio brought 2 points :

Acceptance criteria

Details

My quick notes:

  • the video shows WalletConnect icon for the connector which is not WC

Could you post a screenshot for this point, I am actually confused what you mean by shows WalletConnect icon for the connector which is not WC

  • desktop crashes when left running for a while

Do you have some more information about the crash? any logs to share please? Is it reproducible or it's just a one off? Also any estimation about the amount of time when saying for a while

Also, the component does not seem to be contextual. Meaning that if Account 1 (not All accounts) is elected, dApps for Account 2 can be disconnected.

image

Thanks for bringing this is interesting perspective... 🙏🏾 If I understand what you meant here, the connections should obviously be filtered by account. I believe this should work unless there is a small tweak to make in the WC model fetching. @stefandunca do you confirm that this should work on WC or is there anything in progress?

kounkou commented 1 month ago

Hi @xAlisher

do we have an icon for the connector service to replace in this use case or any recommendations please :

Screenshot from 2024-08-07 19-06-39

xAlisher commented 1 month ago

image image

kounkou commented 1 month ago

Do you have some more information about the crash? any logs to share please? Is it reproducible or it's just a one off? Also any estimation about the amount of time when saying for a while

https://github.com/status-im/status-desktop/pull/15954#issuecomment-2274792049

@MishkaRogachev do you have a Mac please? Would you please be able to check if you have the crash and if it's related to Browser connector plugin please ?

MishkaRogachev commented 1 month ago

@MishkaRogachev do you have a Mac please? Would you please be able to check if you have the crash and if it's related to Browser connector plugin please ?

I assembled a build from the last master, I periodically connect to it through the browser plugin to uniswap, so far no crashes. @xAlisher @felicio what version are you using? Did you do anything in the app other than connect to the browser plugin?

felicio commented 1 month ago

@MishkaRogachev it wasn't the last master.

  1. What's the latest build relevant to the next release and release of the whole feature?
  2. Where to download it?
  3. Which one should QA use?

So we all are testing the same thing.

Here https://ci.status.im/job/status-desktop/ I don't see any periodic builds for https://github.com/status-im/status-desktop/tree/release/2.30.x.

MishkaRogachev commented 1 month ago

@MishkaRogachev do you have a Mac please? Would you please be able to check if you have the crash and if it's related to Browser connector plugin please ?

Uptime for 6 hours, still working, version 2.30-rc.5 release build