Open Samyoul opened 4 weeks ago
Samyoul
commented
3 weeks ago I've just noticed this:
A version of the Desktop app is declaring status-go version 0.179.11, that is the version value of the VERSION file in the status-go repo . See here https://github.com/status-im/status-go/blob/develop/VERSION
caybro
commented
3 weeks ago I've just noticed this:
A version of the Desktop app is declaring
status-goversion0.179.11, that is the version value of theVERSIONfile in thestatus-gorepo . See here https://github.com/status-im/status-go/blob/develop/VERSION
That looks like either the release branch, or an older master branch. It's no longer the case, we use this to get the status-go version number (from Makefile):
STATUSGO_VERSION=`(cd vendor/status-go; git describe --tags --abbrev=0)`which we then display in the Settings/About page. It's not used for any other purpose afaik
Description:
It appears that the Desktop app currently has a concept of the
status-goversion, but this information may not be passed tostatus-goitself. In the mobile app, we utilize astatus-go-version.jsonfile to communicate the version tostatus-go. However, it seems that the Desktop app does not have a similar mechanism in place.Current Behavior:
status-goversion (as shown in the Makefile), but this version is not passed tostatus-go.VERSIONfile appears to be deprecated and is not used in many places anymore.Expected Behavior:
status-goversion information tostatus-go, similar to how it's handled in the mobile app with thestatus-go-version.jsonfile.Steps to Reproduce:
status-goversion is not communicated tostatus-go.You can also inspect the proxy server access logs and see that the
status-goversion is missing from the RPC client User Agent version:Additional Context:
status-go-version.jsonfile to pass the version information tostatus-go.Relevant Links:
status-go-version.json: status-go-version.jsonProposal:
Implement a mechanism in the Desktop app to pass the
status-goversion tostatus-go, ensuring consistency across platforms. This could involve creating a similar JSON file or integrating the version information in another suitable way.