search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
288 stars 78 forks source link

SendModal: Improvements: Missing loading state when ENS name is being resolved #16355

Closed Khushboo-dev-cpp closed 2 weeks ago

Khushboo-dev-cpp commented 2 weeks ago

https://github.com/user-attachments/assets/d65a5ceb-ad51-4461-9e84-beacf9e614b9

As seen in the screenshot when the sendModal is prefilled with an ens name, we can see the recipient selector while the ens name is being resolved. As soon as the ens name is resolved we replace it with the wallet address There is not loading state during this time and its not clear that the ens name is being validated in the background.

Need some designs to handle this usecase.

Description

Summary: ...

Acceptance Criteria

@benjthayer fyi

benjthayer commented 2 weeks ago

Proposed design: https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25380-133002&t=e4UnH984VDFtuhiJ-4

cc @Khushboo-dev-cpp

We'll also look to refine this in the simplified send flow designs (where we remove multichain support).

caybro commented 2 weeks ago

Proposed design: https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25380-133002&t=e4UnH984VDFtuhiJ-4

cc @Khushboo-dev-cpp

We'll also look to refine this in the simplified send flow designs (where we remove multichain support).

@benjthayer can I also see the Paste button in there, together with the spinner and other trailing components? :)

benjthayer commented 2 weeks ago

@benjthayer can I also see the Paste button in there, together with the spinner and other trailing components? :)

Hey @caybro the Paste button should be removed and replaced with the spinner and X clear icon button as soon as a string has been entered. Upon clicking the X clear icon button, the field should clear and the Paste button should be re-instated.

caybro commented 2 weeks ago

@benjthayer can I also see the Paste button in there, together with the spinner and other trailing components? :)

Hey @caybro the Paste button should be removed and replaced with the spinner and X clear icon button as soon as a string has been entered. Upon clicking the X clear icon button, the field should clear and the Paste button should be re-instated.

@benjthayer got it! :) See the video in https://github.com/status-im/status-desktop/pull/16356