status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
288 stars 78 forks source link

Get rid of `HoldingsSelectionModel` #16407

Open micieslak opened 4 days ago

micieslak commented 4 days ago

Description

HoldingsSelectionModel is adaptor-like component from times when the only proxy model available was SFPM. It combines models by doing lookup in expression roles to another models. This mechanism is inefficient and problematic also from pov code structure - data cannot be prepared early in the flow, multiple models must be passed to views and combined already in the view.

It's necessary to review usages HoldingsSelectionModel and build efficient adaptor, how we do it nowadays. Probably also some views can be improved then regarding their API and compliance with the guideline.

micieslak commented 4 days ago

Related PR: https://github.com/status-im/status-desktop/pull/16363