Open osmaczko opened 5 days ago
@osmaczko This should probably be in status-go repo?
@osmaczko This should probably be in status-go repo?
Yes, ideally it should. However, since the parent resides in status-desktop, I would prefer to keep it as is. By the way, I am aware that the parent should also belong to status-go, and it did previously, but I moved it because the goal labels in status-desktop aren't accessible in status-go 🙈
@osmaczko I guess we should copy the goals labels to status-go then.
Description
In status-go, the usage of
geth.Logger
should be replaced withzap.Logger
, and a custom handler should be created for the rootgeth.Logger
to proxy logs to azap.Logger
instance named "geth." This will allow us to filter logs originating from there.Context:
Logs in
geth.log
are incomplete; they do not include the logger name. This issue arises because we are propagating zap logs to the rootgeth.Logger
, which results in the loss of some information. Additionally, this logging flow seems incorrect. Instead ofzap.Logger->geth.Logger
, it should likely begeth.Logger->zap.Logger
(i.e., from a specific logger to a more generic one).Notes
go-ethereum
has updated its logging utility, and when we rebase our fork, we will need to use the SetDefault function instead of SetHandler.