status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 78 forks source link

Swap - The success toast is not launched when a successful swap transaction occurs #16585

Open virginiabalducci opened 3 weeks ago

virginiabalducci commented 3 weeks ago

Bug Report

Description

Steps to reproduce

  1. Perform a successful Swap transaction

Expected behavior

As per user story SD-17 Notifications

Given an Swap transaction succeeds
Then a success toast is launched with text: "Swapped {Input Amount} {Input Asset} to {Output Amount} {Output Asset} in {Selected Account} using {DApp URL} on {Selected Network}"

Figma: https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap---Milestone-1?node-id=3542-496941&node-type=instance&m=dev Image

Actual behavior

No notification toast for successful swap displays

https://github.com/user-attachments/assets/e1967ddb-6624-409b-8b92-18160b47363e

Additional Information

virginiabalducci commented 2 weeks ago

Removing from 2.31 scope as we don't have data available in that format to fix for 2.31 This issue will be worked in base of new designs https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25111-368170&node-type=instance&m=dev and implemented on a future release

Khushboo-dev-cpp commented 1 week ago

@saledjenic Assigning it to you as you will be handling these parts in your notification mechanism rework.