search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
303 stars 79 forks source link

EPIC: Simplified Send Transaction #16696

Open Khushboo-dev-cpp opened 3 weeks ago

Khushboo-dev-cpp commented 3 weeks ago

Description

As a first step in stabilising and having a bug free send, the team has decided to go ahead with single network send as a version 1.

This epic covers all the changes that need to be done in send as finalised by the team.

Designs: https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25182-169274&t=Ech2sOd4zCGhGFzC-4 User Stories: https://www.notion.so/Making-transactions-Send-Bridge-Simplified-1128f96fb65c80d78d6ed0788776e98f?pvs=4

SubComponents Rework:

Main Tasks:

micieslak commented 3 weeks ago

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

Image

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

Khushboo-dev-cpp commented 2 weeks ago

I left some comments in subtasks.

Moreover I noticed one big thing necessary to do along with the planned simplifications. It's consequence of design changes regarding scrolling:

Image

It means that top level layout of SendModal needs to be rethought and organised from scratch with that scrolling behavior in mind. Everything above the list should be put into ListView header probably.

@micieslak this behaviour only applies when screen size < 720 px.

But your suggestion for moving everything above the list to listview header makes sense. We could play with sticky property based on screen height.

anastasiyaig commented 1 day ago

@alaibe @Khushboo-dev-cpp I moved that to 2.33 milestone as we discussed