status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
301 stars 79 forks source link

Browser Connect - SIWE authentication sign does not work on appkit-lab.reown.com #16750

Closed virginiabalducci closed 1 week ago

virginiabalducci commented 1 week ago

Bug Report

Description

Steps to reproduce

  1. Go to https://appkit-lab.reown.com/library/ethers-siwe/
  2. Connect to the dApp via Browser Connect
  3. Accept the connection request on the desktop app's end

Expected behavior

Once the connection is accepted on the dApp's end user sees a 'Sign In' request When clicking on Sign, the Sign authorization dialog should trigger on the desktop app's end, and when user Signs, the dApp should successfully connect through Browser Connect

Actual behavior

Once the connection is accepted on the dApp's end user sees a 'Sign In' request When clicking on Sign, nothing is triggered on the Desktop App's end, and the dApp shows an error message 'Signature declined' On the desktop's end, a toast shows 'Disconnected from appkit-lab.reown.com'

https://github.com/user-attachments/assets/0923a076-bfa6-4f0f-b964-18c61c43f687

Image

Image

Console log app_20241112_092050.log

Additional Information

This dApp works correctly if connected via Wallet Connect.

https://github.com/user-attachments/assets/d60963b4-6264-4d4f-88cb-776a7d1953a6

virginiabalducci commented 1 week ago

cc @alexjba

alexjba commented 1 week ago

@virginiabalducci personal sign is not implemented on BC. I'm just working on it and will add a PR in a few. https://github.com/status-im/status-desktop/issues/16015

alexjba commented 1 week ago

@virginiabalducci For reference, the BC currently implements only send transaction. It's missing: personal_sign, eth_sign, eth_signTypedData_v4, eth_signTypedData, eth_signTransaction

virginiabalducci commented 1 week ago

closing this issue as per the comments