fix(BC): Implementing the personal_sign - Githubissues

status-im / status-desktop

Status Desktop client made in Nim & QML

https://status.app

Mozilla Public License 2.0

301 stars 79 forks source link

fix(BC): Implementing the personal_sign #16751

Closed alexjba closed 2 hours ago

alexjba commented 1 week ago

What does the PR do

Closes: #16015

Introducing personal_sign to Browser Connect. https://docs.metamask.io/wallet/reference/json-rpc-methods/personal_sign/

Needs https://github.com/status-im/status-go/pull/6090

Adding the event handler for personal sign, accept/reject QML slots and accept/reject result signals.

Fixed the send transaction parsing. The parsing has been adding unnecessary arguments to the event even if the arguments had no value.

Affected areas

Browser Connect

Architecture compliance

[x] I am familiar with the application architecture and agreed good practices. My PR is consistent with this document: Status Desktop Architecture Guide

Screenshot of functionality (including design for comparison)

https://github.com/user-attachments/assets/c8e531e4-20f1-49d5-9b45-336a405039b3

[x] I've checked the design and this PR matches it

status-im-auto commented 1 week ago

Jenkins Builds

Click to see older builds (21)

| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/1/) | 2024-11-12 13:31:11 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/1//consoleText) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16751/1/) | 2024-11-12 13:32:11 | ~9 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241112-132245-ca0456-pr16751-aarch64.dmg) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/1/) | 2024-11-12 13:35:18 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/1//consoleText) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16751/1/) | 2024-11-12 13:38:46 | ~16 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241112-132240-ca0456-pr16751-x86_64.nix.tar.gz) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16751/1/) | 2024-11-12 13:39:08 | ~16 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241112-132245-ca0456-pr16751-x86_64.dmg) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16751/1/) | 2024-11-12 13:43:55 | ~21 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241112-132246-ca0456-pr16751-x86_64.exe) | | :heavy_check_mark: | ca0456ec | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16751/1/) | 2024-11-12 13:44:16 | ~21 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241112-132241-ca0456-pr16751-x86_64.tar.gz) | | :x: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16751/2/) | 2024-11-20 14:19:03 | ~2 min | `linux-nix/x86_64` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16751/2/consoleText) | | :x: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16751/2/) | 2024-11-20 14:19:28 | ~2 min | `macos/x86_64` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16751/2/consoleText) | | :heavy_check_mark: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/2/) | 2024-11-20 14:25:06 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/2//consoleText) | | :heavy_check_mark: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16751/2/) | 2024-11-20 14:25:58 | ~9 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-141643-ca0456-pr16751-aarch64.dmg) | | :heavy_check_mark: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/2/) | 2024-11-20 14:29:57 | ~13 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/2//consoleText) | | :heavy_check_mark: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16751/2/) | 2024-11-20 14:35:26 | ~18 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-141640-ca0456-pr16751-x86_64.tar.gz) | | :heavy_check_mark: | ca0456ec | [#2](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16751/2/) | 2024-11-20 14:37:33 | ~20 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-141645-ca0456-pr16751-x86_64.exe) | | :x: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16751/3/) | 2024-11-20 16:12:29 | ~1 min | `macos/aarch64` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16751/3/consoleText) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/3/) | 2024-11-20 16:19:11 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16751/3//consoleText) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/3/) | 2024-11-20 16:23:09 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16751/3//consoleText) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16751/3/) | 2024-11-20 16:23:25 | ~12 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-161051-ca0456-pr16751-x86_64.dmg) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16751/3/) | 2024-11-20 16:25:53 | ~15 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-161045-ca0456-pr16751-x86_64.nix.tar.gz) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16751/3/) | 2024-11-20 16:28:53 | ~18 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-161052-ca0456-pr16751-x86_64.exe) | | :heavy_check_mark: | ca0456ec | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16751/3/) | 2024-11-20 16:32:53 | ~22 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-161046-ca0456-pr16751-x86_64.tar.gz) |

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	4b95df98	#4	2024-11-22 07:57:26	~6 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	4b95df98	#4	2024-11-22 07:59:54	~9 min	`tests/nim`	:page_facing_up:`log`
:heavy_check_mark:	4b95df98	#4	2024-11-22 08:02:06	~11 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	4b95df98	#4	2024-11-22 08:04:36	~14 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	4b95df98	#4	2024-11-22 08:10:36	~19 min	`windows/x86_64`	:cd:`exe`
:heavy_check_mark:	4b95df98	#4	2024-11-22 08:13:04	~22 min	`linux/x86_64`	:package:`tgz`
:heavy_check_mark:	4b95df98	#4	2024-11-22 08:14:18	~23 min	`linux-nix/x86_64`	:package:`tgz`

:heavy_check_mark:	b738ee3d	#5	2024-11-22 08:47:42	~5 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 08:49:51	~8 min	`tests/nim`	:page_facing_up:`log`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 08:53:47	~11 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 08:54:01	~12 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 08:59:07	~17 min	`linux-nix/x86_64`	:package:`tgz`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 09:00:00	~18 min	`windows/x86_64`	:cd:`exe`
:heavy_check_mark:	b738ee3d	#5	2024-11-22 09:04:06	~22 min	`linux/x86_64`	:package:`tgz`