Feat/activity v2 - Githubissues

status-im / status-desktop

Status Desktop client made in Nim & QML

https://status.app

Mozilla Public License 2.0

301 stars 79 forks source link

Feat/activity v2 #16762

Open dlipicar opened 1 week ago

dlipicar commented 1 week ago

Part of https://github.com/status-im/status-desktop/issues/16275 status-go part: https://github.com/status-im/status-go/pull/6102

What does the PR do

Adapt to new ActivityV2 API
Reworked activity context menu
Hide Activity filter
Hide Collectibles details activity tab

Some work was left out of the initial iteration:

Support for some activity types (Community tokens/collectibles txs, DApps)
Repeat transaction option in context menu

Affected areas

Activity, Collectibles Details

Architecture compliance

[ ] I am familiar with the application architecture and agreed good practices. My PR is consistent with this document: Status Desktop Architecture Guide

Screenshot of functionality (including design for comparison)

https://github.com/user-attachments/assets/032c1ad4-dbbc-4995-9454-65209cca3332

[ ] I've checked the design and this PR matches it

status-im-auto commented 1 week ago

Jenkins Builds

Click to see older builds (26)

| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/1/) | 2024-11-15 05:45:04 | ~7 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/1//consoleText) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16762/1/) | 2024-11-15 05:46:18 | ~8 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241115-053732-f9bb09-pr16762-aarch64.dmg) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/1/) | 2024-11-15 05:49:48 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/1//consoleText) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16762/1/) | 2024-11-15 05:55:36 | ~17 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241115-053737-f9bb09-pr16762-x86_64.dmg) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16762/1/) | 2024-11-15 05:59:48 | ~22 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241115-053727-f9bb09-pr16762-x86_64.nix.tar.gz) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16762/1/) | 2024-11-15 05:59:48 | ~22 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241115-053729-f9bb09-pr16762-x86_64.tar.gz) | | :heavy_check_mark: | f9bb0959 | [#1](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16762/1/) | 2024-11-15 06:04:43 | ~27 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241115-053737-f9bb09-pr16762-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | d93d51c9 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16762/2/) | 2024-11-17 20:23:11 | ~7 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-201537-d93d51-pr16762-aarch64.dmg) | | :heavy_check_mark: | d93d51c9 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/2/) | 2024-11-17 20:23:24 | ~7 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/2//consoleText) | | :heavy_check_mark: | d93d51c9 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/2/) | 2024-11-17 20:27:57 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/2//consoleText) | | :heavy_check_mark: | d93d51c9 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16762/2/) | 2024-11-17 20:30:52 | ~15 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-201538-d93d51-pr16762-x86_64.dmg) | | :heavy_check_mark: | d93d51c9 | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16762/2/) | 2024-11-17 20:32:11 | ~16 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-201533-d93d51-pr16762-x86_64.nix.tar.gz) | | | | | | | | | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16762/3/) | 2024-11-17 20:40:42 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-203455-c47ea5-pr16762-aarch64.dmg) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/3/) | 2024-11-17 20:42:22 | ~7 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/3//consoleText) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/3/) | 2024-11-17 20:47:02 | ~12 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/3//consoleText) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16762/3/) | 2024-11-17 20:48:35 | ~13 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-203450-c47ea5-pr16762-x86_64.nix.tar.gz) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16762/3/) | 2024-11-17 20:50:12 | ~15 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-203456-c47ea5-pr16762-x86_64.dmg) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16762/3/) | 2024-11-17 20:53:43 | ~18 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-203452-c47ea5-pr16762-x86_64.tar.gz) | | :heavy_check_mark: | c47ea545 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16762/3/) | 2024-11-17 20:58:34 | ~23 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241117-203459-c47ea5-pr16762-x86_64.exe) | | | | | | | | | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/5/) | 2024-11-18 13:09:33 | ~7 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16762/5//consoleText) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16762/5/) | 2024-11-18 13:10:20 | ~8 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241118-130147-a0e683-pr16762-aarch64.dmg) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/5/) | 2024-11-18 13:13:38 | ~11 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16762/5//consoleText) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16762/5/) | 2024-11-18 13:14:28 | ~12 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241118-130149-a0e683-pr16762-x86_64.dmg) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16762/5/) | 2024-11-18 13:21:45 | ~20 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241118-130142-a0e683-pr16762-x86_64.nix.tar.gz) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16762/5/) | 2024-11-18 13:24:04 | ~22 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241118-130143-a0e683-pr16762-x86_64.tar.gz) | | :heavy_check_mark: | a0e683ea | [#5](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16762/5/) | 2024-11-18 13:26:28 | ~24 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241118-130151-a0e683-pr16762-x86_64.exe) |

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 18:57:59	~7 min	`tests/nim`	:page_facing_up:`log`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 18:58:32	~7 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 19:02:49	~11 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 19:04:06	~13 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 19:04:23	~13 min	`linux-nix/x86_64`	:package:`tgz`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 19:12:12	~21 min	`linux/x86_64`	:package:`tgz`
:heavy_check_mark:	26a1c0ac	#6	2024-11-18 19:14:45	~23 min	`windows/x86_64`	:cd:`exe`

:heavy_check_mark:	4c424c94	#7	2024-11-18 19:32:29	~5 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	4c424c94	#7	2024-11-18 19:34:18	~7 min	`tests/nim`	:page_facing_up:`log`
:x:	4c424c94	#7	2024-11-18 19:39:04	~12 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	4c424c94	#7	2024-11-18 19:41:38	~15 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	4c424c94	#7	2024-11-18 19:45:31	~19 min	`linux-nix/x86_64`	:package:`tgz`
:heavy_check_mark:	4c424c94	#7	2024-11-18 19:47:51	~21 min	`linux/x86_64`	:package:`tgz`
:heavy_check_mark:	4c424c94	#7	2024-11-18 19:48:44	~22 min	`windows/x86_64`	:cd:`exe`
:x:	4c424c94	#8	2024-11-20 13:26:11	~11 min	`tests/ui`	:page_facing_up:`log`

virginiabalducci commented 12 hours ago

Activity has been tested for the following (except Failed statuses)

SD-315 - Send Asset (ETH / ERC20) SD-316 - Sent collectible (ERC721/ERC1155) SD-317 - Bridge Asset SD-318 - Swap Asset SD-319 - Approval for Asset All Accounts vs Specific Account Activity List Items

1 issue found so far: https://github.com/status-im/status-desktop/issues/16788

Need instructions on how to test SD-342 - Unidentified transaction