Closed alexjba closed 2 hours ago
:grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
---|---|---|---|---|---|---|
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:04:25 | ~4 min | macos/aarch64 |
:apple:dmg |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:08:37 | ~8 min | tests/nim |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:12:26 | ~12 min | tests/ui |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:12:53 | ~13 min | macos/x86_64 |
:apple:dmg |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:13:39 | ~13 min | linux-nix/x86_64 |
:package:tgz |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:20:39 | ~20 min | linux/x86_64 |
:package:tgz |
:heavy_check_mark: | f42f3427 | #2 | 2024-11-18 16:25:06 | ~25 min | windows/x86_64 |
:cd:exe |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:23:28 | ~6 min | macos/aarch64 |
:apple:dmg |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:24:19 | ~7 min | tests/nim |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:29:47 | ~12 min | macos/x86_64 |
:apple:dmg |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:31:32 | ~14 min | linux-nix/x86_64 |
:package:tgz |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:31:53 | ~15 min | tests/ui |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:38:19 | ~21 min | linux/x86_64 |
:package:tgz |
:heavy_check_mark: | f42f3427 | #3 | 2024-11-20 14:43:09 | ~26 min | windows/x86_64 |
:cd:exe |
:x: | f42f3427 | #4 | 2024-11-20 16:12:28 | ~1 min | macos/aarch64 |
:page_facing_up:log |
:x: | f42f3427 | #4 | 2024-11-20 16:13:10 | ~2 min | linux-nix/x86_64 |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #4 | 2024-11-20 16:19:37 | ~8 min | tests/nim |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #4 | 2024-11-20 16:24:47 | ~13 min | tests/ui |
:page_facing_up:log |
:heavy_check_mark: | f42f3427 | #4 | 2024-11-20 16:26:40 | ~15 min | macos/x86_64 |
:apple:dmg |
:heavy_check_mark: | f42f3427 | #4 | 2024-11-20 16:32:54 | ~22 min | linux/x86_64 |
:package:tgz |
:heavy_check_mark: | f42f3427 | #4 | 2024-11-20 16:36:24 | ~25 min | windows/x86_64 |
:cd:exe |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 07:58:44 | ~6 min | macos/aarch64 |
:apple:dmg |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:05:11 | ~13 min | tests/nim |
:page_facing_up:log |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:06:34 | ~14 min | macos/x86_64 |
:apple:dmg |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:06:51 | ~14 min | tests/ui |
:page_facing_up:log |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:07:09 | ~15 min | linux-nix/x86_64 |
:package:tgz |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:08:57 | ~17 min | linux/x86_64 |
:package:tgz |
:heavy_check_mark: | ff6faf8d | #5 | 2024-11-22 08:18:02 | ~26 min | windows/x86_64 |
:cd:exe |
Wallet connect transactions look good. Browser connect transaction had an issue which was fixed here https://github.com/status-im/status-desktop/pull/16771 There are some transaction type on BC that are pending testing because they have not been developed yet
What does the PR do
Closes: #16747 #16004 #16116 #16755
What all these issues have in common is that the
gas
to be used by the transaction was hardcoded to 21k. To fix this we're computing the gas for each transaction if it's not being supplied by the dapp.The full fix includes:
AnimatedText
to allow a custom target property to animate. The fees component need to animatecustomText
property and not thetext
property.There are some updates to the fees computation required by the new dapps architecture. Since the fees requests are now async I've reused the
SubscriptionBroker
mechanism used in other parts of the app to manage the request periodicity and bundling when the same request is needed by two subscribers (WC or BC).This PR moves the fees computation from
SignRequestPlugin
to theTransactionFeesBroker
- component used to manage the periodic backend calls and theTransactionFeesSubscriber
- component that aggregates the backend responses and computes the fees. TheTransactionFeesSubscriber
will receive data from 3 different requests (requestSuggestedFees
,requestGasEstimate
,requestEstimatedTime
). This data is aggregated and transformed in a ready to be consumed format for the UI.New user stories:
Affected areas
Wallet Connect, Browser Connect
Architecture compliance
Screenshot of functionality (including design for comparison)
Uniswap tx - User has enough for fees
https://github.com/user-attachments/assets/982bc1ba-4a3a-4360-b844-03e5b5f345e2
Rarible tx - custom gas. A comparison with Coinbase fees computation. The user does not have enough for fees
https://github.com/user-attachments/assets/2b7bb3dd-46b6-4b5e-bf7d-7c22b2b8c180
yearn.fy - Withdraw flow
https://github.com/user-attachments/assets/8e8059db-a22b-4dc7-ab0e-2db1313eb7cb
yearn.fy - Deposit flow
https://github.com/user-attachments/assets/5509fbc4-aeee-4b2c-927b-6cd4251e7b68