feat(WalletFirst): Rearrange left nav bar and open wallet section by default

alexjba commented 2 days ago

What does the PR do

Closes #16778

Wallet section is the default section
Wallet section is the first section in the left nav bar

Acceptance criteria:

Wallet is loaded after onboarding Wallet is the first item in the left side bar The active session is persisted after restart

Affected areas

Left nav bar The default active section Active section persistency

Architecture compliance

[x] I am familiar with the application architecture and agreed good practices. My PR is consistent with this document: Status Desktop Architecture Guide

Screenshot of functionality (including design for comparison)

[x] I've checked the design and this PR matches it

https://github.com/user-attachments/assets/2cd66578-1124-4b00-aa09-46277e7ca446

User stories:

Given the user has logged in
When the app starts
Then the wallet button is the first one in the left navigation bar

Given the user has signed up for a new account
When the onboarding process ends
Then the wallet section is displayed

Given the user has selected [chat,wallet,community,communityPortal] section
And quits the app
When the user logs in again
Then the last selected section is displayed

Given the user has selected settings section
And quits the app
When the user logs in again
The the wallet section is displayed

status-im-auto commented 2 days ago

Jenkins Builds

Click to see older builds (37)

| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/1/) | 2024-11-20 08:24:49 | ~6 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-081806-f19f72-pr16783-aarch64.dmg) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/1/) | 2024-11-20 08:26:44 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/1//consoleText) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/1/) | 2024-11-20 08:31:40 | ~13 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/1//consoleText) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16783/1/) | 2024-11-20 08:36:13 | ~18 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-081806-f19f72-pr16783-x86_64.dmg) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16783/1/) | 2024-11-20 08:40:26 | ~22 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-081800-f19f72-pr16783-x86_64.nix.tar.gz) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16783/1/) | 2024-11-20 08:40:38 | ~22 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-081808-f19f72-pr16783-x86_64.exe) | | :heavy_check_mark: | f19f72bd | [#1](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16783/1/) | 2024-11-20 08:42:56 | ~24 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-081801-f19f72-pr16783-x86_64.tar.gz) | | | | | | | | | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/2/) | 2024-11-20 10:36:52 | ~5 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-103103-5fab5f-pr16783-aarch64.dmg) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/2/) | 2024-11-20 10:39:14 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/2//consoleText) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/2/) | 2024-11-20 10:42:33 | ~11 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/2//consoleText) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16783/2/) | 2024-11-20 10:44:59 | ~13 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-103104-5fab5f-pr16783-x86_64.dmg) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16783/2/) | 2024-11-20 10:50:48 | ~19 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-103057-5fab5f-pr16783-x86_64.nix.tar.gz) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16783/2/) | 2024-11-20 10:51:23 | ~20 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-103105-5fab5f-pr16783-x86_64.exe) | | :heavy_check_mark: | 5fab5f0e | [#2](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16783/2/) | 2024-11-20 10:52:52 | ~21 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-103058-5fab5f-pr16783-x86_64.tar.gz) | | | | | | | | | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/3/) | 2024-11-20 12:35:06 | ~4 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-123051-163543-pr16783-aarch64.dmg) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/3/) | 2024-11-20 12:39:03 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/3//consoleText) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/3/) | 2024-11-20 12:44:01 | ~13 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/3//consoleText) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16783/3/) | 2024-11-20 12:44:21 | ~13 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-123053-163543-pr16783-x86_64.dmg) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16783/3/) | 2024-11-20 12:49:55 | ~19 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-123046-163543-pr16783-x86_64.nix.tar.gz) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16783/3/) | 2024-11-20 12:51:22 | ~20 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-123055-163543-pr16783-x86_64.exe) | | :heavy_check_mark: | 16354356 | [#3](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16783/3/) | 2024-11-20 12:53:19 | ~22 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-123047-163543-pr16783-x86_64.tar.gz) | | | | | | | | | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/4/) | 2024-11-20 16:41:11 | ~6 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-163501-775ad2-pr16783-aarch64.dmg) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/4/) | 2024-11-20 16:43:19 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/4//consoleText) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/4/) | 2024-11-20 16:48:18 | ~13 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/4//consoleText) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16783/4/) | 2024-11-20 16:50:28 | ~15 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-163502-775ad2-pr16783-x86_64.dmg) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16783/4/) | 2024-11-20 16:53:45 | ~18 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-163455-775ad2-pr16783-x86_64.nix.tar.gz) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16783/4/) | 2024-11-20 16:55:40 | ~20 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-163505-775ad2-pr16783-x86_64.exe) | | :heavy_check_mark: | 775ad2c8 | [#4](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16783/4/) | 2024-11-20 16:56:58 | ~22 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241120-163457-775ad2-pr16783-x86_64.tar.gz) | | | | | | | | | | :heavy_check_mark: | bbe5cb7e | [#5](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/5/) | 2024-11-21 11:15:05 | ~4 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111006-bbe5cb-pr16783-aarch64.dmg) | | :heavy_check_mark: | bbe5cb7e | [#5](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/5/) | 2024-11-21 11:18:40 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/5//consoleText) | | | | | | | | | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/aarch64/job/package/job/PR-16783/6/) | 2024-11-21 11:27:31 | ~8 min | `macos/aarch64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111902-c24208-pr16783-aarch64.dmg) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/6/) | 2024-11-21 11:27:37 | ~8 min | `tests/nim` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-nim/job/PR-16783/6//consoleText) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/6/) | 2024-11-21 11:32:34 | ~13 min | `tests/ui` | [:page_facing_up:`log`](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/tests-ui/job/PR-16783/6//consoleText) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/macos/job/x86_64/job/package/job/PR-16783/6/) | 2024-11-21 11:35:32 | ~16 min | `macos/x86_64` | [:apple:`dmg`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111904-c24208-pr16783-x86_64.dmg) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package-nix/job/PR-16783/6/) | 2024-11-21 11:39:34 | ~20 min | `linux-nix/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111857-c24208-pr16783-x86_64.nix.tar.gz) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/windows/job/x86_64/job/package/job/PR-16783/6/) | 2024-11-21 11:43:43 | ~24 min | `windows/x86_64` | [:cd:`exe`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111904-c24208-pr16783-x86_64.exe) | | :heavy_check_mark: | c242085b | [#6](https://ci.status.im/job/status-desktop/job/prs/job/linux/job/x86_64/job/package/job/PR-16783/6/) | 2024-11-21 11:43:48 | ~24 min | `linux/x86_64` | [:package:`tgz`](https://status-im-desktop-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-241121-111859-c24208-pr16783-x86_64.tar.gz) |

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	93841425	#7	2024-11-21 13:46:04	~4 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	93841425	#7	2024-11-21 13:49:33	~8 min	`tests/nim`	:page_facing_up:`log`
:heavy_check_mark:	93841425	#7	2024-11-21 13:52:40	~11 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	93841425	#7	2024-11-21 13:55:58	~14 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	93841425	#7	2024-11-21 14:00:48	~19 min	`linux-nix/x86_64`	:package:`tgz`
:heavy_check_mark:	93841425	#7	2024-11-21 14:03:14	~21 min	`windows/x86_64`	:cd:`exe`
:heavy_check_mark:	93841425	#7	2024-11-21 14:03:41	~22 min	`linux/x86_64`	:package:`tgz`

:heavy_check_mark:	2e1d63b8	#8	2024-11-22 07:49:36	~5 min	`macos/aarch64`	:apple:`dmg`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 07:52:09	~8 min	`tests/nim`	:page_facing_up:`log`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 07:56:58	~13 min	`tests/ui`	:page_facing_up:`log`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 07:59:24	~15 min	`macos/x86_64`	:apple:`dmg`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 08:02:43	~18 min	`linux-nix/x86_64`	:package:`tgz`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 08:03:55	~20 min	`linux/x86_64`	:package:`tgz`
:heavy_check_mark:	2e1d63b8	#8	2024-11-22 08:05:24	~21 min	`windows/x86_64`	:cd:`exe`

alexjba commented 2 days ago

@anastasiyaig Looks like we need to update the e2e as well

anastasiyaig commented 2 days ago

ya i will do it soon @alexjba

status-im-auto commented 2 days ago

:heavy_check_mark: status-desktop/prs/linux/x86_64/tests-nim/PR-16783#3 :small_blue_diamond: ~8 min 26 sec :small_blue_diamond: 16354356 :small_blue_diamond: :package: tests/nim package

anastasiyaig commented 21 hours ago

i tested that and it works matching the acceptance criteria defined deep links are also working, tried community link, link to profile, link to send in chat i also finally fixed autotests (commit in this PR) this is good to be merged

alexjba commented 5 hours ago

Good job!

Btw, it would be nice to get rid of the concept of "section" from the NIM side and handle the app layout exclusively on the UI side. But I'm not sure how big effort it is.

Not sure either. But could be something worth investigating. I'll can add an analysis task to see if it's feasible.

status-im / status-desktop