search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
301 stars 79 forks source link

Added the legal docs as a submodule #16791

Open Samyoul opened 23 hours ago

Samyoul commented 23 hours ago

Resolves https://github.com/status-im/status-desktop/issues/16787 See https://github.com/status-im/status-software-legal-documents/issues/5 Also see: https://github.com/status-im/status-mobile/pull/21654

Adding the status-software-legal-documents repo as a submodule makes life easier by keeping all legal documents consistent across platforms. Instead of copying files around and hoping they stay in sync, we can just point to the same source. This way, any updates to the main legal docs automatically flow to all the repos, reducing the chances of mistakes or outdated files. It’s a simple, reliable way to stay organised and keep everything aligned.

Samyoul commented 23 hours ago

If you @status-im/desktop-core guys want me to move the submodule somewhere else I am happy to do that, I just placed it in the same dir as the existing legal docs

status-im-auto commented 23 hours ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:31:12 ~8 min tests/nim :page_facing_up:log
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:31:31 ~8 min macos/aarch64 :apple:dmg
:x: 92f02fe8 #1 2024-11-21 12:37:11 ~14 min tests/ui :page_facing_up:log
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:38:15 ~15 min macos/x86_64 :apple:dmg
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:42:44 ~19 min linux-nix/x86_64 :package:tgz
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:43:14 ~20 min linux/x86_64 :package:tgz
:heavy_check_mark: 92f02fe8 #1 2024-11-21 12:43:55 ~20 min windows/x86_64 :cd:exe
igor-sirotin commented 23 hours ago

... move the submodule somewhere else I am happy to do that

@Samyoul I guess it would make sense to be in the vendor directory. But depends on if we import these files in QML or not, I have no idea 🙂 cc @alexjba @micieslak

alexjba commented 23 hours ago

... move the submodule somewhere else I am happy to do that

@Samyoul I guess it would make sense to be in the vendor directory. But depends on if we import these files in QML or not, I have no idea 🙂 cc @alexjba @micieslak

I think you're right! vendor seems to be the right place. Even if we'll need it in qml, we'll find a way. As we do now for qzxing

caybro commented 23 hours ago

... move the submodule somewhere else I am happy to do that

@Samyoul I guess it would make sense to be in the vendor directory. But depends on if we import these files in QML or not, I have no idea 🙂 cc @alexjba @micieslak

Yeah... good point; the idea is that we'll want to import these Markdown files, instead of ui/imports/assets/docs/privacy.mdwn and ui/imports/assets/docs/terms-of-use.mdwn

alexjba commented 23 hours ago

Yeah... good point; the idea is that we'll want to import these Markdown files, instead of ui/imports/assets/docs/privacy.mdwn and ui/imports/assets/docs/terms-of-use.mdwn

StatusQ is already importing vendor modules. Do you think it will be an issue to add this as well as a dependency?

caybro commented 22 hours ago

Yeah... good point; the idea is that we'll want to import these Markdown files, instead of ui/imports/assets/docs/privacy.mdwn and ui/imports/assets/docs/terms-of-use.mdwn

StatusQ is already importing vendor modules. Do you think it will be an issue to add this as well as a dependency?

Dunno, we just need to make sure it gets included in the autogenerated qrc file

Samyoul commented 17 hours ago

@alexjba and @caybro is it possible to replace the use of ui/imports/assets/docs/privacy.mdwn and ui/imports/assets/docs/terms-of-use.mdwn with the contents of https://github.com/status-im/status-software-legal-documents?

So instead of pulling in the markdown from this repo it gets pulled in directly from https://github.com/status-im/status-software-legal-documents?

caybro commented 15 hours ago

@alexjba and @caybro is it possible to replace the use of ui/imports/assets/docs/privacy.mdwn and ui/imports/assets/docs/terms-of-use.mdwn with the contents of https://github.com/status-im/status-software-legal-documents?

So instead of pulling in the markdown from this repo it gets pulled in directly from https://github.com/status-im/status-software-legal-documents?

Yeah, I think it would be just a matter of fixing the ui/generate-rcc.go to include those 2 files from the submodule, and maybe adjusting some paths in QML