status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 79 forks source link

Chat: block user #8805

Open anastasiyaig opened 1 year ago

anastasiyaig commented 1 year ago

Description

The requirements gathered here are based on the information got from mobile team

As a user, I can block a contact


from https://github.com/status-im/status-desktop/issues/8975

Background Design have done a body of work to make the flows and implications around Blocking a user more comprehensive. Through this body of work it was confirmed with @John-44 that when a user blocks another user, the blocked user should also be kicked from all ad-hoc group chats owned by the blocking user and banned from all Communities owned by the blocking user.

This should be clarified to the blocking user at the point at which they select to block a user via the following confirm block dialog which contains a checkbox which is selected and disabled stating:

Ban [Display name] from all current and future Group Chats and Communities that I own

Confirm block dialog

Figma: https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?node-id=1503%3A14889&t=33ycAeE4YzwiKHlD-1

anastasiyaig commented 1 year ago

@benjthayer @John-44 i need your review on blocking user functionality. We should align it with mobile and here is a short summary of requirements that i got from mobile QAs. Please review, comment, edit and provide figma for this so we can have it implemented.

@jrainville please check this out as it goes to messenger team functionality

@iurimatias please prioritise

@glitchminer @elina2015 please be aware

anastasiyaig commented 1 year ago

UPD per @benjthayer:

Just to confirm, the more comprehensive block user flows are almost complete pending a final review from the team. They can be found here:

https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?node-id=1503%3A14889&t=33ycAeE4YzwiKHlD-1

NOTE: not yet confirmed

benjthayer commented 1 year ago

Hey @anastasiyaig @iurimatias as far as I am aware, these designs are complete and have been reviewed between myself and John. Is there anything further required?

anastasiyaig commented 1 year ago

@benjthayer thank u for getting back! @iurimatias @jrainville @John-44 do we want it for mvp or later?

igor-sirotin commented 1 year ago

Linking this, as it introduced an explicit difference in desktop/mobile:

John-44 commented 1 year ago

Linking this, as it introduced an explicit difference in desktop/mobile:

@cammellos @iurimatias @anastasiyaig is a difference between Status Desktop and Status Mobile warranted here?

I would have thought that the 'Block user' behaviour should be identical on both Mobile and Desktop.

IMHO when a user is blocked on both Status Desktop or Status Mobile (it shouldn't matter which), then:

Then, on all of the users devices (both Desktop and Mobile), it should appear as if that user 'doesn't exist, and never existed' to the user who blocked them. Specifically, this means that:

I can't see why there should be any difference in the above functionality between Mobile and Desktop, esp. as blocked users must be synced across all of the user's devices, and therefor I would have thought that the fact that a user has been blocked should be acted upon in the same way on all of the user's devices (both Mobile and Desktop. But perhaps I'm missing something?

anastasiyaig commented 1 year ago

@John-44 the feature must be identical on both platforms and this is the purpose of this task - to align it. Sadly it was logged 7 months ago , so things could have been changed since then. The description of the task could be adjusted, the main goal is again to make this feature identical :)

igor-sirotin commented 1 year ago

I'm also fixing syncing problems related to blocking contacts in https://github.com/status-im/status-desktop/issues/11523 🙂

iurimatias commented 8 months ago

moving to 2.29 due to lack of space in this milestone and lack of clarify in this task