Deleting notifications from the activity center

[MishkaRogachev]

Using soft-delete provided in status-go library by this PR implement feature of deleting activity center notifications by ui

[MishkaRogachev]

@benjthayer, can I get a design for this feature?

Maybe a trash bin button on hover?

[benjthayer]

Thanks @MishkaRogachev - actually some work to do to on this to ensure we have the room to add the delete icon to all notification types.

Currently, the structure of these notification list items isn't very well defined in terms of the max width allowed for the main text area and what space and margins is reserved for the controls and statuses to the right of the list item.

I feel it might be an opportune moment to spend a bit of time auditing these activity centre variants and clarifying a structure for all AC items to follow which accommodates all necessary controls and statuses. WDYT @John-44

[MishkaRogachev]

@mprakhov I am afraid that this feature may conflict with the fact that the user can delete the confirmation notification when transferring community ownership. If we don't have a different UI for ownership confirmation, maybe we should add a new field to the AC notification that prohibits deleting this notification until the action has been performed.

[mprakhov]

I don't see any problems with deleting the notifications. It's just a notification. Ownership transfers only when token transferred and this can be done via wallet too

[iurimatias]

moving to 2.29 as it needs design and lack fo space in this milestone

[iurimatias]

@MishkaRogachev what is the use case here, delete a notification? and where did this requirement came from (e.g mobile does this?)

@benjthayer is this something we want to implement? and in that case how would it look like

[MishkaRogachev]

@MishkaRogachev what is the use case here, delete a notification? and where did this requirement came from (e.g mobile does this?)

Yes, it's from mobile, it is already implemented there

[benjthayer]

@MishkaRogachev what is the use case here, delete a notification? and where did this requirement came from (e.g mobile does this?)

@benjthayer is this something we want to implement? and in that case how would it look like

Yes, this is something we will likely want to do for desktop - but not really something we can squeeze into the cracks of higher priority items. We would likely want to look at notification centre items holistically when adding this functionality in given the structure of notification centre items needs work.

Mobile designs for ref: https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?type=design&node-id=5387-523340&mode=design&t=JrJIbmYRPbQPhU2u-4