Enable support for larger images and audio messages (increase max size setting)

John-44 commented 1 year ago

Edit

The chunking part is done. See this comment: https://github.com/status-im/status-desktop/issues/9923#issuecomment-2009389837

The missing part is increasing the Max size for binaries.

Problem:

Waku isn't designed to send large messages
libp2p (which Waku is built on top of) is in the process of being optimised by ProtocolLabs and others for messages up to 125kb in size, as part of the work to implement Ethereum's DankSharding (EIP-4844)
Users expect good quality images in a messaging app, but Status currently has a 300kb image size limit, and images that user's post are recompressed to fit inside this size limit (which means that large images currently look rubbish in Status).
It would be nice to raise the length limit for audio messages in the future
We would like to allow users to share small files (e.g. up to 2mb) in the future
The community web onboarding screens (the screen a user who doesn't have Status installed arrives on when they open a community URL that has been sent to them in a browser) requires communities to use a large high quality image as their banner (see example screen below)

Solution

Add support to status-go to split binary files that are larger than 125kb into several waku messages, each with a 125kb payload. Then at the recipient's end, reconstruct the binary from these multiple waku messages.
Increase the max size limit for each image sent in a message to 1.5mb. If an image is less than 1.5mb it should not be recompressed. If an image is larger than 1.5mb it should be recompressed to 1.5mb using the recompression functionality that is already in status-go today.
Increase the max size of audio messages to 1.5mb (e.g. at it's largest size, it would be split into twelve 125kb waku messages)
Increase the max size of community banner images to 2.5mb (e.g. at it's largest size, it would be split into twenty 125kb waku messages)
Set the max size of a community logo image as 250kb (e.g. at it's largest size, it would be split into two 125kb waku messages)
Set the max size of a user avatar image as 125kb (e.g. at it's largest size, it would be split into two 125kb waku messages)

Other notes

This feature should be worked on by the Desktop team (not the Mobile team, because the Mobile has more work to do to get to MVP)
The desktop team shouldn't work on this feature until after the 0.13 release
Before starting work on this feature, whoever is going to implement it should speak to both @cammellos (because this is an approach that @cammellos has already been thinking about) and @felicio (because @felicio will need to add support for this into status.js)

cc'ing @iurimatias

jrainville commented 11 months ago

FYI, there is a strong chance that https://github.com/status-im/status-desktop/issues/12188 fixes this issue as well, since we'll do a more generic solution that chunks messages that exceed the waku limit

iurimatias commented 8 months ago

moving to 2.29 due to lack of space in this milestone, however this could be done in the stabilization period with other refactors if there is room

osmaczko commented 7 months ago

Add support to status-go to split binary files that are larger than 125kb into several waku messages, each with a 125kb payload. Then at the recipient's end, reconstruct the binary from these multiple waku messages.

That's been addressed with https://github.com/status-im/status-go/pull/4285. The solution is generic, allowing it to split any message payload that exceeds the limit. Currently, the limit for one segment is 0.75 MiB, but this can easily be changed and will remain backward-compatible.

jrainville commented 7 months ago

I feel like we could close this issue, though we didn't increase the max size of binaries, so maybe we can keep it opened until we actually do the increases and test them.

cammellos commented 5 months ago

This looks like it should be descoped after the offsite discussion, what do you think @John-44 @jo-mut @iurimatias @osmaczko ?

jo-mut commented 5 months ago

it would be nice to have this however, at this moment it does not look to be a priority issue, its fair to descope it

cammellos commented 5 months ago

sorry @jo-mut , I meant to ping @jrainville , but thanks for sharing your opinion, I fully agree with you!

iurimatias commented 2 months ago

descoped for now

status-im / status-desktop