status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
727 stars 246 forks source link

Improve Bookmark syncing #2704

Closed 0x-r4bbit closed 2 years ago

0x-r4bbit commented 2 years ago

Syncing bookmarks today works as follows:

This task is about ensuring that syncing bookmarks is done in real-time, when adding/deleting bookmarks, not just when syncing devices.

The deleting scenario for now will be done by simply setting the existing removed flag to true in the bookmarks table which is then synced. UIs will then have to check for removed to figure out whether or not they want to display bookmarks

This also means that bookmarks are never really deleted, this will be tackled by a garbage collection mechanism, described in this issue: https://github.com/status-im/status-go/issues/2705

0x-r4bbit commented 2 years ago

This has landed as of https://github.com/status-im/status-go/issues/2704