search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 246 forks source link

Fix linter warning across the whole project #435

Closed adambabik closed 7 years ago

adambabik commented 7 years ago

Problem

As we integrated pretty a lot of linters into our CI pipeline, there are many warning identified.

Implementation

Fix all warning reported by make lint across the whole project.

goimports should be removed as we agreed that gofmt sorts modules good enough.

Acceptance Criteria

  1. make lint reports no errors/warnings.

Notes

It's a blocker because none PR will be able to pass CI checks.

b00ris commented 7 years ago

It was fixed twise. At #388 and #387. Why do we need it? New warnings are coming from uncleaned PR.

tiabc commented 7 years ago

@adambabik as you've noticed that, can you fix that, please? I don't think it'll take a lot of time.

adambabik commented 7 years ago

Done https://github.com/status-im/status-go/pull/436