search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

fix(activity)_: report other token types than ERC20 #5406

Open stefandunca opened 1 week ago

stefandunca commented 1 week ago

Closes: #15233

This fixes incremental updates for tokens and proper report of token type for mobile (in desktop we didn't use it)

status-im-auto commented 1 week ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 81a660227ee5bfb5a9496d74a9a2f30953f8fe7c #1 2024-06-22 08:37:32 ~4 min linux :package:zip
:heavy_check_mark: 81a660227ee5bfb5a9496d74a9a2f30953f8fe7c #1 2024-06-22 08:37:43 ~4 min ios :package:zip
:heavy_check_mark: 81a660227ee5bfb5a9496d74a9a2f30953f8fe7c #1 2024-06-22 08:39:00 ~5 min android :package:aar
:heavy_check_mark: 81a66022 #1 2024-06-22 09:15:44 ~42 min tests :page_facing_up:log
stefandunca commented 1 week ago

Hey @ulisesmac please have a look at my changes and check if it fixes the issues you reported. It works for desktop, I get the notifications, the NFT name si reported on the client side. The token URL is missing though, that must be a collectible fetching issue at first glance.

ulisesmac commented 3 days ago

Hey @ulisesmac please have a look at my changes and check if it fixes the issues you reported. It works for desktop, I get the notifications, the NFT name si reported on the client side. The token URL is missing though, that must be a collectible fetching issue at first glance.

Hey @stefandunca !

Thanks for the update, and sorry for the late response on this.

  1. :white_check_mark: The collectible type is now fixed!

  2. :white_check_mark:

    After checking the request ID is not delivered with the payload but with the walletevent.Event

    Yes, you are right!, thanks for the clarification

  3. The signal wallet-activity-filtering-entries-updated seems still btoken, it returns repeated entries and doesn't return the data for all the NFT transactions.

    This is the signal response for the address 0x779425b89cd705c83ae588e458efed05c9f90f9b:

[{"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0x9d043a75b0687780fa6d5d668effab920d511ba953f37993a8b993985e4a84fa","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0x9d043a75b0687780fa6d5d668effab920d511ba953f37993a8b993985e4a84fa","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0xba9acc92d9dc5c442f6fe8bca970673c0cb8dba4c74fdd89aba680ef8d6d161b","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""},
 {"payloadType":2,"transaction":{"chainId":11155111,"hash":"0x9d043a75b0687780fa6d5d668effab920d511ba953f37993a8b993985e4a84fa","address":"0x779425b89cd705c83ae588e458efed05c9f90f9b"},"nftName":"Genesis","nftUrl":""}]

  1. The balances for 1155 tokens are not in WEI, is it right?

  2. The token URL is missing though, that must be a collectible fetching issue at first glance.

    Will we open a follow-up to address it?