search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

chore_: move extkeys submodule to cmd #5410

Open siddarthkay opened 1 week ago

siddarthkay commented 1 week ago

Summary

we currently use extkeys as a submodule which has a separate go version and our status-go project has a different go version. For consistency sake its better if the source was within status-go and not as a submodule. If we want a submodule it should be in a separate github repository so that this submodule could be maintained and updated and we don't need 2 PRs to make changes to extkeys

In this PR I move the code within extkeys submodule to cmd folder and I update its imports and usages within status-go.

status-im-auto commented 1 week ago

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: ceff480ab795c352662d93d4fb39c21efcb24238 #1 2024-06-24 07:47:13 ~3 min ios :package:zip
:heavy_check_mark: ceff480ab795c352662d93d4fb39c21efcb24238 #1 2024-06-24 07:47:31 ~4 min linux :package:zip
:heavy_check_mark: ceff480ab795c352662d93d4fb39c21efcb24238 #1 2024-06-24 07:48:50 ~5 min android :package:aar
:heavy_check_mark: ceff480a #1 2024-06-24 08:27:05 ~43 min tests :page_facing_up:log