Router v2 integration - Githubissues

saledjenic commented 5 days ago

What's done in this PR:

GetSuggestedRoutesV2Async exposed via wallet API which calculates the best route in an async way and notifies the client via "wallet.suggested.routes" signal
Old wallet event with signal type "wallet" and event type "sign-transaction", like this {"type":"wallet","event":{"type":"sing-transactions", "transactions":["0x123", ...] .... } } is now set to signal type "wallet.sign.transactions" and looks like this {"type":"wallet.sign.transactions","event":["0x123", ...] }
A ew event type added "wallet.suggested.routes", it carries the best path (list of paths v2) or error (code and description)

status-im-auto commented 5 days ago

Jenkins Builds

Click to see older builds (43)

| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/1/) | 2024-06-26 07:52:06 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-074753-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.zip) | | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/1/) | 2024-06-26 07:52:36 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-074753-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.zip) | | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/1/) | 2024-06-26 07:53:33 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-074753-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.aar) | | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/2/) | 2024-06-26 10:06:49 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-100434-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.zip) | | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/2/) | 2024-06-26 10:07:44 | ~3 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-100434-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.zip) | | :heavy_check_mark: | 388b4eefb251e326b205149633ca541ad7077d7c | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/2/) | 2024-06-26 10:11:43 | ~7 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-100434-388b4eefb251e326b205149633ca541ad7077d7c-pr5426.aar) | | | | | | | | | | :heavy_check_mark: | 388b4eef | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/1/) | 2024-06-26 08:31:54 | ~43 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/1//consoleText) | | :heavy_check_mark: | 388b4eef | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/2/) | 2024-06-26 10:48:56 | ~44 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/2//consoleText) | | | | | | | | | | :heavy_check_mark: | 342e8470b85753895423c47630ce14516ece8081 | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/3/) | 2024-06-26 10:11:44 | ~3 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-100813-342e8470b85753895423c47630ce14516ece8081-pr5426.zip) | | :heavy_check_mark: | 342e8470b85753895423c47630ce14516ece8081 | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/3/) | 2024-06-26 10:12:06 | ~3 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-100807-342e8470b85753895423c47630ce14516ece8081-pr5426.zip) | | :heavy_check_mark: | 342e8470b85753895423c47630ce14516ece8081 | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/3/) | 2024-06-26 10:21:10 | ~9 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-101159-342e8470b85753895423c47630ce14516ece8081-pr5426.aar) | | | | | | | | | | :heavy_multiplication_x: | 342e8470 | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/3/) | 2024-06-26 11:29:53 | ~40 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/3//consoleText) | | | | | | | | | | :heavy_check_mark: | 81601a306a2a122b389215729b80365444fd3a7e | [#4](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/4/) | 2024-06-26 13:34:29 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-133201-81601a306a2a122b389215729b80365444fd3a7e-pr5426.zip) | | :heavy_check_mark: | 81601a306a2a122b389215729b80365444fd3a7e | [#4](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/4/) | 2024-06-26 13:36:04 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-133201-81601a306a2a122b389215729b80365444fd3a7e-pr5426.zip) | | :heavy_check_mark: | 81601a306a2a122b389215729b80365444fd3a7e | [#4](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/4/) | 2024-06-26 13:37:31 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-133201-81601a306a2a122b389215729b80365444fd3a7e-pr5426.aar) | | | | | | | | | | :heavy_check_mark: | 81601a30 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/4/) | 2024-06-26 14:17:15 | ~45 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/4//consoleText) | | | | | | | | | | :heavy_check_mark: | 80266209 | [#5](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/5/) | 2024-06-26 19:51:27 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-194856-802662-pr5426.aar) | | :heavy_check_mark: | 80266209 | [#5](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/5/) | 2024-06-26 19:52:13 | ~3 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-194856-802662-pr5426.zip) | | :heavy_check_mark: | 80266209 | [#5](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/5/) | 2024-06-26 19:53:05 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-194859-802662-pr5426.zip) | | :heavy_check_mark: | 80266209 | [#5](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/5/) | 2024-06-26 20:31:29 | ~42 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/5//consoleText) | | | | | | | | | | :heavy_check_mark: | d3626039 | [#6](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/6/) | 2024-06-27 09:41:55 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-093934-d36260-pr5426.aar) | | :heavy_check_mark: | d3626039 | [#6](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/6/) | 2024-06-27 09:43:48 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-093938-d36260-pr5426.zip) | | :heavy_multiplication_x: | d3626039 | [#6](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/6/) | 2024-06-27 09:45:43 | ~6 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/6//consoleText) | | | | | | | | | | :heavy_check_mark: | ac23170e | [#7](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/7/) | 2024-06-27 11:06:42 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-110439-ac2317-pr5426.aar) | | :heavy_check_mark: | ac23170e | [#7](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/7/) | 2024-06-27 11:06:56 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-110439-ac2317-pr5426.zip) | | :heavy_multiplication_x: | ac23170e | [#7](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/7/) | 2024-06-27 11:38:49 | ~34 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/7//consoleText) | | :heavy_check_mark: | ac23170e | [#8](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/8/) | 2024-06-27 12:30:36 | ~41 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/8//consoleText) | | :x: | ac23170e | [#12](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/12/) | 2024-06-27 14:09:39 | ~7 sec | `ios` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/12/consoleText) | | | | | | | | | | :heavy_check_mark: | bfd16186 | [#8](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/8/) | 2024-06-27 15:04:39 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-150230-bfd161-pr5426.aar) | | :heavy_check_mark: | bfd16186 | [#8](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/8/) | 2024-06-27 15:04:57 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-150234-bfd161-pr5426.zip) | | :heavy_check_mark: | bfd16186 | [#9](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/9/) | 2024-06-27 15:44:16 | ~41 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/9//consoleText) | | | | | | | | | | :heavy_check_mark: | d047f0f5 | [#9](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/9/) | 2024-06-28 06:28:33 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-062623-d047f0-pr5426.aar) | | :heavy_check_mark: | d047f0f5 | [#9](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/9/) | 2024-06-28 06:28:46 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-062627-d047f0-pr5426.zip) | | :heavy_check_mark: | d047f0f5 | [#15](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/15/) | 2024-06-28 06:30:31 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-062627-d047f0-pr5426.zip) | | :heavy_check_mark: | d047f0f5 | [#10](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/10/) | 2024-06-28 07:08:27 | ~41 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/10//consoleText) | | | | | | | | | | :heavy_check_mark: | 7398100b | [#10](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/10/) | 2024-06-28 13:55:06 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-135246-739810-pr5426.aar) | | :heavy_check_mark: | 7398100b | [#10](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/10/) | 2024-06-28 13:55:14 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-135250-739810-pr5426.zip) | | :heavy_check_mark: | 7398100b | [#16](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/16/) | 2024-06-28 13:55:45 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-135246-739810-pr5426.zip) | | :heavy_multiplication_x: | 7398100b | [#11](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/11/) | 2024-06-28 13:59:31 | ~6 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/11//consoleText) | | | | | | | | | | :heavy_check_mark: | b01af610 | [#11](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5426/11/) | 2024-06-30 20:49:36 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240630-204707-b01af6-pr5426.aar) | | :heavy_check_mark: | b01af610 | [#11](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5426/11/) | 2024-06-30 20:49:39 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240630-204712-b01af6-pr5426.zip) | | :heavy_check_mark: | b01af610 | [#17](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5426/17/) | 2024-06-30 20:50:23 | ~3 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240630-204712-b01af6-pr5426.zip) | | :heavy_check_mark: | b01af610 | [#12](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/12/) | 2024-06-30 21:31:15 | ~44 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5426/12//consoleText) |

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	654ba937	#18	2024-07-01 11:24:37	~4 min	`ios`	:package:`zip`
:heavy_check_mark:	654ba937	#12	2024-07-01 11:32:10	~11 min	`linux`	:package:`zip`
:heavy_check_mark:	654ba937	#12	2024-07-01 11:35:37	~15 min	`android`	:package:`aar`
:heavy_check_mark:	654ba937	#13	2024-07-01 12:12:07	~51 min	`tests`	:page_facing_up:`log`

:heavy_check_mark:	9759e74d	#19	2024-07-01 11:49:09	~2 min	`ios`	:package:`zip`
:heavy_check_mark:	9759e74d	#13	2024-07-01 11:52:14	~6 min	`linux`	:package:`zip`
:heavy_check_mark:	9759e74d	#13	2024-07-01 11:53:22	~7 min	`android`	:package:`aar`
:heavy_check_mark:	9759e74d	#14	2024-07-01 12:57:02	~44 min	`tests`	:page_facing_up:`log`

saledjenic commented 5 days ago

@ilmotta changes done here should not affect the mobile app since it doesn't respond to sing-transactions signal (you will start using it when you implement keycard tx signing).

ilmotta commented 4 days ago

@ilmotta changes done here should not affect the mobile app since it doesn't respond to sing-transactions signal (you will start using it when you implement keycard tx signing).

@qfrank, since you will be touching transaction signing via keycard, this is probably of interest to you.

saledjenic commented 4 days ago

I added uuid for async calls and also added an endpoint to stop async tasks, it can be used by the client when the sending modal is about to be closed.

saledjenic commented 17 hours ago

Please check the third commit here this one, it's an important one, which is fixing the issue described here https://github.com/status-im/status-desktop/pull/15344#issuecomment-2196438083

It does this: If there are multiple routes across multiple networks, but the user doesn't have a positive balance on the network which the router initially suggested as the best (cheapest) route, then we are not returning an error saying there is not enough balance, but instead try to suggest the route on the network where the user has a positive balance even if that's not the cheapest route (it should be the second cheapest route, but if there is not enough balance on it we proceed with the third cheapest route and so on...).

status-im / status-go

Router v2 integration #5426

Jenkins Builds