search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

chore_: exclude cmd from test coverage #5427

Closed igor-sirotin closed 4 days ago

igor-sirotin commented 5 days ago

The snow blowers crew agreed that in our case compile is enough for the ./cmd directory

./cmd/statusd/ package affects the coverage, because there'sflags_test.go`. As soon as there's at least 1 test in the package, it starts to affect the whole project test coverage. Therefore, this PR is blocked e.g: https://github.com/status-im/status-go/pull/5346

status-im-auto commented 5 days ago

Jenkins Builds

Click to see older builds (4) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | e6a33098e40555f93cee7ce0f81f911ecabe000c | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5427/1/) | 2024-06-26 13:37:13 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240626-133251-e6a33098e40555f93cee7ce0f81f911ecabe000c-pr5427.zip) | | :heavy_check_mark: | e6a33098e40555f93cee7ce0f81f911ecabe000c | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5427/1/) | 2024-06-26 13:41:42 | ~8 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240626-133251-e6a33098e40555f93cee7ce0f81f911ecabe000c-pr5427.zip) | | :heavy_check_mark: | e6a33098e40555f93cee7ce0f81f911ecabe000c | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5427/1/) | 2024-06-26 13:45:31 | ~12 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240626-133251-e6a33098e40555f93cee7ce0f81f911ecabe000c-pr5427.aar) | | | | | | | | | | :heavy_check_mark: | e6a33098 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5427/1/) | 2024-06-26 14:25:02 | ~52 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5427/1//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: e4cee09bebb8d081ca8e58c4a465baeb9f695702 #2 2024-06-26 14:31:44 ~1 min android :package:aar
:heavy_check_mark: e4cee09bebb8d081ca8e58c4a465baeb9f695702 #2 2024-06-26 14:32:05 ~1 min linux :package:zip
:heavy_check_mark: e4cee09bebb8d081ca8e58c4a465baeb9f695702 #2 2024-06-26 14:32:49 ~2 min ios :package:zip
:heavy_check_mark: e4cee09b #2 2024-06-26 15:13:21 ~43 min tests :page_facing_up:log
igor-sirotin commented 5 days ago

Working example:

image

100% coverage despite introduced new line:

image