search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
719 stars 243 forks source link

Feat: add `eth_requestAccounts` implementation #5433

Open MishkaRogachev opened 3 days ago

MishkaRogachev commented 3 days ago

Waits https://github.com/status-im/status-go/pull/5418/

Disclaimer: This PR is draft, description will be updated later

status-im-auto commented 3 days ago

Jenkins Builds

Click to see older builds (29) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_multiplication_x: | c00d7b6c | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/1/) | 2024-06-27 16:21:44 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/1//consoleText) | | :heavy_check_mark: | c00d7b6c | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/1/) | 2024-06-27 16:24:12 | ~3 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-162024-c00d7b-pr5433.zip) | | :heavy_check_mark: | c00d7b6c | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/1/) | 2024-06-27 16:24:33 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240627-162024-c00d7b-pr5433.zip) | | :heavy_check_mark: | c00d7b6c | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/1/) | 2024-06-27 16:25:42 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-162024-c00d7b-pr5433.aar) | | | | | | | | | | :heavy_multiplication_x: | 57363d9e | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/2/) | 2024-06-27 16:22:53 | ~55 sec | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/2//consoleText) | | :heavy_multiplication_x: | 57363d9e | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/3/) | 2024-06-27 16:24:06 | ~58 sec | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/3//consoleText) | | :heavy_check_mark: | 57363d9e | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/2/) | 2024-06-27 16:26:47 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-162428-57363d-pr5433.zip) | | :heavy_check_mark: | 57363d9e | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/2/) | 2024-06-27 16:27:45 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240627-162452-57363d-pr5433.zip) | | :heavy_check_mark: | 57363d9e | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/2/) | 2024-06-27 16:31:19 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-162603-57363d-pr5433.aar) | | | | | | | | | | :heavy_multiplication_x: | 98266f91 | [#4](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/4/) | 2024-06-27 19:52:53 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/4//consoleText) | | :heavy_check_mark: | 98266f91 | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/3/) | 2024-06-27 19:53:52 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-195144-98266f-pr5433.zip) | | :heavy_check_mark: | 98266f91 | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/3/) | 2024-06-27 19:54:19 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240627-195140-98266f-pr5433.zip) | | :heavy_check_mark: | 98266f91 | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/3/) | 2024-06-27 19:57:05 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-195140-98266f-pr5433.aar) | | | | | | | | | | :heavy_multiplication_x: | 895f0f6f | [#5](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/5/) | 2024-06-27 19:59:53 | ~1 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/5//consoleText) | | :heavy_check_mark: | 895f0f6f | [#4](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/4/) | 2024-06-27 20:00:31 | ~1 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-195840-895f0f-pr5433.aar) | | :heavy_check_mark: | 895f0f6f | [#4](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/4/) | 2024-06-27 20:00:42 | ~1 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-195844-895f0f-pr5433.zip) | | :heavy_check_mark: | 895f0f6f | [#4](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/4/) | 2024-06-27 20:01:26 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240627-195844-895f0f-pr5433.zip) | | | | | | | | | | :heavy_multiplication_x: | d61497a8 | [#6](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/6/) | 2024-06-28 12:34:51 | ~55 sec | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/6//consoleText) | | :heavy_check_mark: | d61497a8 | [#5](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/5/) | 2024-06-28 12:36:18 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-123355-d61497-pr5433.aar) | | :heavy_check_mark: | d61497a8 | [#5](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/5/) | 2024-06-28 12:36:48 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-123355-d61497-pr5433.zip) | | :heavy_check_mark: | d61497a8 | [#5](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/5/) | 2024-06-28 12:37:47 | ~3 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-123355-d61497-pr5433.zip) | | | | | | | | | | :heavy_multiplication_x: | b98758ee | [#7](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/7/) | 2024-06-28 14:21:43 | ~57 sec | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/7//consoleText) | | :heavy_check_mark: | b98758ee | [#6](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/6/) | 2024-06-28 14:23:10 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-142041-b98758-pr5433.zip) | | :heavy_check_mark: | b98758ee | [#6](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/6/) | 2024-06-28 14:23:12 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-142041-b98758-pr5433.aar) | | :heavy_multiplication_x: | b98758ee | [#8](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/8/) | 2024-06-28 14:23:23 | ~56 sec | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5433/8//consoleText) | | :heavy_check_mark: | b98758ee | [#6](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/6/) | 2024-06-28 14:23:41 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-142041-b98758-pr5433.zip) | | :heavy_check_mark: | b98758ee | [#7](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5433/7/) | 2024-06-28 14:25:43 | ~2 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-142326-b98758-pr5433.zip) | | :heavy_check_mark: | b98758ee | [#7](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5433/7/) | 2024-06-28 14:25:53 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-142328-b98758-pr5433.aar) | | :heavy_check_mark: | b98758ee | [#7](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5433/7/) | 2024-06-28 14:26:29 | ~2 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-142358-b98758-pr5433.zip) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: 53a3839d #9 2024-06-28 14:58:07 ~1 min tests :page_facing_up:log
:heavy_check_mark: 53a3839d #8 2024-06-28 14:58:47 ~1 min android :package:aar
:heavy_check_mark: 53a3839d #8 2024-06-28 14:59:31 ~2 min ios :package:zip
:heavy_check_mark: 53a3839d #8 2024-06-28 15:00:52 ~4 min linux :package:zip
:heavy_multiplication_x: 88c272a3 #10 2024-06-28 16:19:44 ~1 min tests :page_facing_up:log
:heavy_check_mark: 88c272a3 #9 2024-06-28 16:20:09 ~1 min android :package:aar
:heavy_check_mark: 88c272a3 #9 2024-06-28 16:20:50 ~2 min linux :package:zip
:heavy_check_mark: 88c272a3 #9 2024-06-28 16:21:06 ~2 min ios :package:zip
kounkou commented 3 days ago

Nice changes!, thanks @MishkaRogachev, let me add them to the root branch if you don't mind, so that you can focus on the method implementation you want to work on. Just a general question, Have you thought how the commands would call the CallRPC method ?