search

status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 246 forks source link

fix(dapps)_: fix bugs and expose wallet_GetWalletConnectActiveSessions API #5434

Closed stefandunca closed 2 months ago

stefandunca commented 3 months ago

Updates #15189

Required by https://github.com/status-im/status-desktop/pull/15322

Changes

status-im-auto commented 3 months ago

Jenkins Builds

Click to see older builds (12) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | 85660e17 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5434/1/) | 2024-06-27 16:50:15 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240627-164608-85660e-pr5434.zip) | | :heavy_check_mark: | 85660e17 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5434/1/) | 2024-06-27 16:50:30 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240627-164608-85660e-pr5434.zip) | | :heavy_check_mark: | 85660e17 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5434/1/) | 2024-06-27 16:51:29 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240627-164604-85660e-pr5434.aar) | | :heavy_check_mark: | 85660e17 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/1/) | 2024-06-27 17:29:49 | ~43 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/1//consoleText) | | | | | | | | | | :heavy_check_mark: | 928941a6 | [#2](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5434/2/) | 2024-07-02 10:58:16 | ~2 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240702-105603-928941-pr5434.aar) | | :heavy_check_mark: | 928941a6 | [#2](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5434/2/) | 2024-07-02 11:00:04 | ~3 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240702-105607-928941-pr5434.zip) | | :heavy_check_mark: | 928941a6 | [#2](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5434/2/) | 2024-07-02 11:00:52 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240702-105607-928941-pr5434.zip) | | :heavy_check_mark: | 928941a6 | [#2](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/2/) | 2024-07-02 11:39:41 | ~43 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/2//consoleText) | | | | | | | | | | :heavy_multiplication_x: | a26b75fe | [#3](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/3/) | 2024-07-02 13:31:17 | ~2 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5434/3//consoleText) | | :heavy_check_mark: | a26b75fe | [#3](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5434/3/) | 2024-07-02 13:31:40 | ~3 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240702-132838-a26b75-pr5434.zip) | | :heavy_check_mark: | a26b75fe | [#3](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5434/3/) | 2024-07-02 13:33:13 | ~4 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240702-132838-a26b75-pr5434.zip) | | :heavy_check_mark: | a26b75fe | [#3](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5434/3/) | 2024-07-02 13:34:52 | ~6 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240702-132834-a26b75-pr5434.aar) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: b1af4650 #4 2024-07-02 13:36:13 ~2 min tests :page_facing_up:log
:heavy_check_mark: b1af4650 #4 2024-07-02 13:36:17 ~2 min ios :package:zip
:heavy_check_mark: b1af4650 #4 2024-07-02 13:37:14 ~2 min android :package:aar
:heavy_check_mark: b1af4650 #4 2024-07-02 13:37:23 ~3 min linux :package:zip
:heavy_check_mark: e0c762c0 #5 2024-07-02 13:39:30 ~1 min android :package:aar
:heavy_check_mark: e0c762c0 #5 2024-07-02 13:39:46 ~2 min linux :package:zip
:heavy_check_mark: e0c762c0 #5 2024-07-02 13:39:59 ~3 min ios :package:zip
:heavy_multiplication_x: e0c762c0 #5 2024-07-02 14:19:11 ~42 min tests :page_facing_up:log
:heavy_multiplication_x: e0c762c0 #6 2024-07-02 15:25:04 ~19 min tests :page_facing_up:log
:heavy_check_mark: e0c762c0 #7 2024-07-02 17:02:26 ~42 min tests :page_facing_up:log
stefandunca commented 2 months ago

image

@igor-sirotin all the added lines are green in my test coverage could you please help me understand why the 20% coverage?

igor-sirotin commented 2 months ago

@igor-sirotin all the added lines are green in my test coverage

Well this is not correct 🙂

This is the only line that's covered:

image

These are not covered:

image

This remained "not affecting the test coverage":

image

The problem here is that it doesn't make sense to write tests for services/wallet/api.go. I'm aware of this problem and will take care of it soon.

Meanwhile we can force-merge it @cammellos

stefandunca commented 2 months ago

Well this is not correct 🙂

Indeed, I missed that I have to be logged in the coverage extension to have the extra thick green/red bar.

The problem here is that it doesn't make sense to write tests for services/wallet/api.go. I'm aware of this problem and will take care of it soon.

After logging in I figure out and wrote a test for it. Please remove it in your PR when fixing it.