status-im / status-go

The Status module that consumes go-ethereum
https://status.im
Mozilla Public License 2.0
728 stars 246 forks source link

fix(unfurl)_: The application crashes when generating status user profile link preview #5441

Closed friofry closed 3 months ago

friofry commented 3 months ago

It happened because FetchContact returned the contact and the error both nil

Closes status-im/status-desktop#15297

https://github.com/status-im/status-go/assets/1083341/04f943c6-010c-4636-a860-249d03308638

status-im-auto commented 3 months ago

Jenkins Builds

Click to see older builds (4) | :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | |-|-|-|-|-|-|-| | :heavy_check_mark: | c3d00e69 | [#1](https://ci.status.im/job/status-go/job/prs/job/linux/job/PR-5441/1/) | 2024-06-28 11:52:32 | ~3 min | `linux` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-desktop-240628-114830-c3d00e-pr5441.zip) | | :heavy_check_mark: | c3d00e69 | [#1](https://ci.status.im/job/status-go/job/prs/job/ios/job/PR-5441/1/) | 2024-06-28 11:53:06 | ~4 min | `ios` | [:package:`zip`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-ios-240628-114830-c3d00e-pr5441.zip) | | :heavy_check_mark: | c3d00e69 | [#1](https://ci.status.im/job/status-go/job/prs/job/android/job/PR-5441/1/) | 2024-06-28 11:54:25 | ~5 min | `android` | [:package:`aar`](https://status-im-prs.ams3.cdn.digitaloceanspaces.com/status-go-android-240628-114830-c3d00e-pr5441.aar) | | :heavy_check_mark: | c3d00e69 | [#1](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5441/1/) | 2024-06-28 12:32:49 | ~44 min | `tests` | [:page_facing_up:`log`](https://ci.status.im/job/status-go/job/prs/job/tests/job/PR-5441/1//consoleText) |
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 695bd2c5 #2 2024-06-28 15:32:59 ~2 min android :package:aar
:heavy_check_mark: 695bd2c5 #2 2024-06-28 15:33:41 ~2 min ios :package:zip
:heavy_check_mark: 695bd2c5 #2 2024-06-28 15:34:38 ~3 min linux :package:zip
:heavy_check_mark: 695bd2c5 #2 2024-06-28 16:14:05 ~43 min tests :page_facing_up:log
:heavy_check_mark: 81c9ffcf #3 2024-06-28 15:50:36 ~2 min android :package:aar
:heavy_check_mark: 81c9ffcf #3 2024-06-28 15:50:43 ~2 min linux :package:zip
:heavy_check_mark: 81c9ffcf #3 2024-06-28 15:51:19 ~2 min ios :package:zip
:heavy_check_mark: 81c9ffcf #3 2024-06-28 16:56:09 ~41 min tests :page_facing_up:log